Remove remaining mentions of UNSAFE_STAT_OK
Started by Peter Eisentrautover 3 years ago1 messages
The last use of UNSAFE_STAT_OK was removed in
bed90759fcbcd72d4d06969eebab81e47326f9a2, but the build system(s) still
mentions it. Is it safe to remove, or does it interact with system
header files in some way that isn't obvious here?
Attachments:
0001-Remove-remaining-mentions-of-UNSAFE_STAT_OK.patchtext/plain; charset=UTF-8; name=0001-Remove-remaining-mentions-of-UNSAFE_STAT_OK.patchDownload
From 594268d54fd344348aa547bc0d3fa6393255a52b Mon Sep 17 00:00:00 2001
From: Peter Eisentraut <peter@eisentraut.org>
Date: Mon, 15 Aug 2022 10:39:07 +0200
Subject: [PATCH] Remove remaining mentions of UNSAFE_STAT_OK
The last use was removed by bed90759fcbcd72d4d06969eebab81e47326f9a2.
---
src/interfaces/libpq/Makefile | 2 +-
src/tools/msvc/Mkvcbuild.pm | 1 -
2 files changed, 1 insertion(+), 2 deletions(-)
diff --git a/src/interfaces/libpq/Makefile b/src/interfaces/libpq/Makefile
index 8abdb092c2..79c574eeb8 100644
--- a/src/interfaces/libpq/Makefile
+++ b/src/interfaces/libpq/Makefile
@@ -22,7 +22,7 @@ NAME= pq
SO_MAJOR_VERSION= 5
SO_MINOR_VERSION= $(MAJORVERSION)
-override CPPFLAGS := -DFRONTEND -DUNSAFE_STAT_OK -I$(srcdir) $(CPPFLAGS) -I$(top_builddir)/src/port -I$(top_srcdir)/src/port
+override CPPFLAGS := -DFRONTEND -I$(srcdir) $(CPPFLAGS) -I$(top_builddir)/src/port -I$(top_srcdir)/src/port
ifneq ($(PORTNAME), win32)
override CFLAGS += $(PTHREAD_CFLAGS)
endif
diff --git a/src/tools/msvc/Mkvcbuild.pm b/src/tools/msvc/Mkvcbuild.pm
index 85d03372a5..ee963d85f3 100644
--- a/src/tools/msvc/Mkvcbuild.pm
+++ b/src/tools/msvc/Mkvcbuild.pm
@@ -266,7 +266,6 @@ sub mkvcbuild
$libpq = $solution->AddProject('libpq', 'dll', 'interfaces',
'src/interfaces/libpq');
$libpq->AddDefine('FRONTEND');
- $libpq->AddDefine('UNSAFE_STAT_OK');
$libpq->AddIncludeDir('src/port');
$libpq->AddLibrary('secur32.lib');
$libpq->AddLibrary('ws2_32.lib');
--
2.37.1