Another dead configure test
I happened to notice that configure extracts TCL_SHLIB_LD_LIBS
from tclConfig.sh, and puts the value into Makefile.global,
but then we never use it anywhere. AFAICT the only use went
away in cd75f94da, in 2003. I propose the attached.
regards, tom lane
Attachments:
remove-unused-symbol.patchtext/x-diff; charset=us-ascii; name=remove-unused-symbol.patchDownload+1-4
Hi,
On 2022-08-18 11:04:03 -0400, Tom Lane wrote:
I happened to notice that configure extracts TCL_SHLIB_LD_LIBS
from tclConfig.sh, and puts the value into Makefile.global,
but then we never use it anywhere. AFAICT the only use went
away in cd75f94da, in 2003. I propose the attached.
Looks good, except that it perhaps could go a tad further: TCL_SHARED_BUILD
isn't used either afaics?
Greetings,
Andres Freund
Andres Freund <andres@anarazel.de> writes:
Looks good, except that it perhaps could go a tad further: TCL_SHARED_BUILD
isn't used either afaics?
I wondered about that, but we do need TCL_SHARED_BUILD in configure
itself, and the PGAC_EVAL_TCLCONFIGSH macro is going to AC_SUBST it.
We could remove the line in Makefile.global but I don't think that
buys much, and it might be more confusing not less so.
regards, tom lane
Hi,
On 2022-08-18 13:00:28 -0400, Tom Lane wrote:
Andres Freund <andres@anarazel.de> writes:
Looks good, except that it perhaps could go a tad further: TCL_SHARED_BUILD
isn't used either afaics?I wondered about that, but we do need TCL_SHARED_BUILD in configure
itself, and the PGAC_EVAL_TCLCONFIGSH macro is going to AC_SUBST it.
We could remove the line in Makefile.global but I don't think that
buys much, and it might be more confusing not less so.
From the meson-generates-Makefile.global angle I like fewer symbols that have
to be considered in Makefile.global.in :). But even leaving that aside, I
think it's clearer to not have things in Makefile.global if they're not used.
But it's obviously not important.
Greetings,
Andres Freund
Andres Freund <andres@anarazel.de> writes:
On 2022-08-18 13:00:28 -0400, Tom Lane wrote:
I wondered about that, but we do need TCL_SHARED_BUILD in configure
itself, and the PGAC_EVAL_TCLCONFIGSH macro is going to AC_SUBST it.
We could remove the line in Makefile.global but I don't think that
buys much, and it might be more confusing not less so.
From the meson-generates-Makefile.global angle I like fewer symbols that have
to be considered in Makefile.global.in :). But even leaving that aside, I
think it's clearer to not have things in Makefile.global if they're not used.
But it's obviously not important.
Yeah, I'm not excited about it either way --- feel free to change
if you'd rather.
regards, tom lane