Removing dead code in pgcrypto
mbuf_tell and mbuf_rewind functions were introduced in commit e94dd6ab91 but
were seemingly never used, so it seems we can consider retiring them in v16.
--
Daniel Gustafsson https://vmware.com/
Attachments:
v1-0001-pgcrypto-Remove-unused-mbuf-code.patchapplication/octet-stream; name=v1-0001-pgcrypto-Remove-unused-mbuf-code.patch; x-unix-mode=0644Download+0-16
Hi Daniel,
it seems we can consider retiring them in v16.
Looks good to me. A link to the discussion was added to the patch.
--
Best regards,
Aleksander Alekseev
Attachments:
v2-0001-pgcrypto-Remove-unused-mbuf-code.patchapplication/octet-stream; name=v2-0001-pgcrypto-Remove-unused-mbuf-code.patchDownload+0-16
On 30 Aug 2022, at 14:39, Aleksander Alekseev <aleksander@timescale.com> wrote:
Hi Daniel,
it seems we can consider retiring them in v16.
Looks good to me. A link to the discussion was added to the patch.
Thanks for looking! On closer inspection, I found another function which was
never used and which doesn't turn up when searching extensions. The attached
removes pgp_get_cipher_name as well.
--
Daniel Gustafsson https://vmware.com/
Attachments:
v3-0001-pgcrypto-Remove-unused-code.patchapplication/octet-stream; name=v3-0001-pgcrypto-Remove-unused-code.patch; x-unix-mode=0644Download+0-27
Hi Daniel,
Thanks for looking! On closer inspection, I found another function which was
never used and which doesn't turn up when searching extensions. The attached
removes pgp_get_cipher_name as well.
I'm pretty sure this change is fine too, but I added the patch to the
CF application in order to play it safe. Let's see what cfbot will
tell us.
--
Best regards,
Aleksander Alekseev