warning: comparison of integer expressions of different signedness related to simd.h

On Sat, Sep 3, 2022 at 12:30 PM Pavel Stehule <pavel.stehule@gmail.com> wrote:

Hi

I got fresh warnings when I build an extension

In file included from /usr/local/pgsql/master/include/server/mb/pg_wchar.h:22,
from src/format.c:17:
/usr/local/pgsql/master/include/server/port/simd.h: In function ‘vector8_has’:
/usr/local/pgsql/master/include/server/port/simd.h:168:27: warning: comparison of integer expressions of different signedness: ‘int’ and ‘long unsigned int’ [-Wsign-compare]
168 | for (int i = 0; i < sizeof(Vector8); i++)
| ^

"int" should probably be "Size" -- does that remove the warning?

--
John Naylor
EDB: http://www.enterprisedb.com

so 3. 9. 2022 v 7:50 odesílatel John Naylor <john.naylor@enterprisedb.com>
napsal:

On Sat, Sep 3, 2022 at 12:30 PM Pavel Stehule <pavel.stehule@gmail.com>
wrote:

Hi

I got fresh warnings when I build an extension

In file included from

/usr/local/pgsql/master/include/server/mb/pg_wchar.h:22,

from src/format.c:17:
/usr/local/pgsql/master/include/server/port/simd.h: In function

‘vector8_has’:

/usr/local/pgsql/master/include/server/port/simd.h:168:27: warning:

comparison of integer expressions of different signedness: ‘int’ and ‘long
unsigned int’ [-Wsign-compare]

168 | for (int i = 0; i < sizeof(Vector8); i++)
| ^

"int" should probably be "Size" -- does that remove the warning?

yes, it removes warnings

Pavel

John Naylor <john.naylor@enterprisedb.com> writes:

On Sat, Sep 3, 2022 at 12:30 PM Pavel Stehule <pavel.stehule@gmail.com> wrote:

/usr/local/pgsql/master/include/server/port/simd.h: In function ‘vector8_has’:
/usr/local/pgsql/master/include/server/port/simd.h:168:27: warning: comparison of integer expressions of different signedness: ‘int’ and ‘long unsigned int’ [-Wsign-compare]
168 | for (int i = 0; i < sizeof(Vector8); i++)

"int" should probably be "Size" -- does that remove the warning?

Agreed, should be Size or size_t, or else cast the sizeof() result.
But I wonder why none of the buildfarm is showing such a warning.

regards, tom lane

so 3. 9. 2022 v 7:57 odesílatel Tom Lane <tgl@sss.pgh.pa.us> napsal:

John Naylor <john.naylor@enterprisedb.com> writes:

On Sat, Sep 3, 2022 at 12:30 PM Pavel Stehule <pavel.stehule@gmail.com>

wrote:

/usr/local/pgsql/master/include/server/port/simd.h: In function

‘vector8_has’:

/usr/local/pgsql/master/include/server/port/simd.h:168:27: warning:

comparison of integer expressions of different signedness: ‘int’ and ‘long
unsigned int’ [-Wsign-compare]

168 | for (int i = 0; i < sizeof(Vector8); i++)

"int" should probably be "Size" -- does that remove the warning?

Agreed, should be Size or size_t, or else cast the sizeof() result.
But I wonder why none of the buildfarm is showing such a warning.

I got this warning when I compiled plgsql_check against master with enabled
asserts

https://github.com/okbob/plpgsql_check

In file included from
/usr/local/pgsql/master/include/server/mb/pg_wchar.h:22,
from src/format.c:17:
/usr/local/pgsql/master/include/server/port/simd.h: In function
‘vector8_has_le’:
/usr/local/pgsql/master/include/server/port/simd.h:219:27: warning:
comparison of integer expressions of different signedness: ‘int’ and ‘long
unsigned int’ [-Wsign-compare]
219 | for (int i = 0; i < sizeof(Vector8); i++)
| ^

On Sat, Sep 3, 2022 at 12:57 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:

John Naylor <john.naylor@enterprisedb.com> writes:

On Sat, Sep 3, 2022 at 12:30 PM Pavel Stehule <pavel.stehule@gmail.com> wrote:

/usr/local/pgsql/master/include/server/port/simd.h: In function ‘vector8_has’:
/usr/local/pgsql/master/include/server/port/simd.h:168:27: warning: comparison of integer expressions of different signedness: ‘int’ and ‘long unsigned int’ [-Wsign-compare]
168 | for (int i = 0; i < sizeof(Vector8); i++)

"int" should probably be "Size" -- does that remove the warning?

Agreed, should be Size or size_t, or else cast the sizeof() result.
But I wonder why none of the buildfarm is showing such a warning.

If I add -Wsign-compare to CPPFLAGS, I get dozens of warnings all over
the place. It's probably unreasonable for extensions to expect to
compile cleanly with warnings that the core server doesn't use, but
this header is clearly wrong and easy to remedy, so I've pushed a
patch.

--
John Naylor
EDB: http://www.enterprisedb.com