Fix wrong syntax about CREATE_REPLICATION_SLOT

Started by tachikake.ayaki@fujitsu.comover 3 years ago2 messageshackers
Jump to latest
#1tachikake.ayaki@fujitsu.com
tachikake.ayaki@fujitsu.com

Hi hackers,

A minor bug was found in the "CREATE_REPLICATION_SLOT" syntax.
It is in protocol.sgml at line 1990.

The current syntax written in it is as follows,

CREATE_REPLICATION_SLOT slot_name [ TEMPORARY ] { PHYSICAL | LOGICAL } [ ( option [, ...] ) ]

However, when I executed a command as follows, that became syntax error.

CREATE_REPLICATION_SLOT tachi LOGICAL;
ERROR: syntax error

To use LOGICAL, output_plugin must be required.
Correct syntax is as follows.

CREATE_REPLICATION_SLOT slot_name [ TEMPORARY ] { PHYSICAL | LOGICAL output_plugin } [ ( option [, ...] ) ]

PSA patch to fix it.

Note that version 15 must also be fixed.

Best Regards,
Ayaki Tachikake
FUJITSU LIMITED

Attachments:

doc.patchapplication/octet-stream; name=doc.patchDownload+1-1
#2Michael Paquier
michael@paquier.xyz
In reply to: tachikake.ayaki@fujitsu.com (#1)
Re: Fix wrong syntax about CREATE_REPLICATION_SLOT

On Wed, Oct 12, 2022 at 08:33:43AM +0000, tachikake.ayaki@fujitsu.com wrote:

Hi hackers,

A minor bug was found in the "CREATE_REPLICATION_SLOT" syntax.
It is in protocol.sgml at line 1990.

Indeed, right. The command is described two times, in its old and new
fashions and the new flavor is incorrect.
--
Michael