[meson] add missing pg_attribute_aligned for MSVC in meson build
Hackorum builds and tests every patch posted to the lists, not only commitfest submissions. This is Hackorum's own CI rather than the PostgreSQL project's, and it is still under testing - please report anything that looks wrong.
You can run a PostgreSQL built from this patch straight from Docker, with no checkout and no build:
docker run --rm -p 5432:5432 ghcr.io/hackorum-dev/postgres-patch:t46781psql -h localhost -U postgresBuilt from patchset v3 (message #3), August 18, 2026 at 03:41 PM.
Every patchset is also pushed to a branch of our PostgreSQL fork, so you can check out the same tree CI built. Without a PostgreSQL checkout:
git clone --branch t46781_3 https://github.com/hackorum-dev/postgres.gitIn a checkout you already have, add the fork once:
git remote add hackorum https://github.com/hackorum-dev/postgres.gitthen, for this patchset and every later one:
git fetch hackorum t46781_3 && git checkout t46781_3Patchset v3 (message #3) is on t46781_3
Hi Andres,
Commit ec3c9cc add pg_attribute_aligned in MSVC[1]/messages/by-id/CAAaqYe-HbtZvR3msoMtk+hYW2S0e0OapzMW8icSMYTMA+mN8Aw@mail.gmail.com,
which was pushed one day before the meson commits,
so meson build missed this feature.
[1]: /messages/by-id/CAAaqYe-HbtZvR3msoMtk+hYW2S0e0OapzMW8icSMYTMA+mN8Aw@mail.gmail.com
--
Regards
Junwang Zhao
Attachments:
0001-meson-add-missing-pg_attribute_aligned-for-MSVC.patchapplication/octet-stream; name=0001-meson-add-missing-pg_attribute_aligned-for-MSVC.patchDownload+2-1
On Fri, Oct 14, 2022 at 10:59:28AM +0800, Junwang Zhao wrote:
Commit ec3c9cc add pg_attribute_aligned in MSVC[1],
which was pushed one day before the meson commits,
so meson build missed this feature.[1]: /messages/by-id/CAAaqYe-HbtZvR3msoMtk+hYW2S0e0OapzMW8icSMYTMA+mN8Aw@mail.gmail.com
Right, thanks! And it is possible to rely on _MSC_VER for that in
this code path.
--
Michael
Hi,
On 2022-10-14 10:59:28 +0800, Junwang Zhao wrote:
Commit ec3c9cc add pg_attribute_aligned in MSVC[1],
which was pushed one day before the meson commits,
so meson build missed this feature.
Good catch. It shouldn't have practical consequences for the moment, given
that msvc doesn't support 128bit integers, but of course we should still be
correct.
Looked through other recent changes to configure and found a few additional
omissions.
See the attached patch fixing those omissions. I'll push it to HEAD once it
has the CI stamp of approval.
Greetings,
Andres Freund