Oct 2022

6 commits
Fix unlink() for STATUS_DELETE_PENDING on Windows.
25 Oct 2022Thomas Munromaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1Also in: pgsql: Move any remaining files generated by pg_upgrade into an interna (not this thread)
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #20 of 1 reviewer saw the final version

The src/port/dirmod.c implementation matches #2, explicitly detecting STATUS_DELETE_PENDING to reach the unlink retry loop; only tests were omitted and surrounding context adjusted #3. The verdict in thread #46599 agrees that this submission supersedes its earlier matching patch #517229; its later submissions postdate the commit.

  • Michael Paquierno review foundtrailerMichael's review credit is already present in #2 alongside the discussion link to thread #46599, but no review activity by him appears in this thread.
Fix stat() for recursive junction points on Windows.
25 Oct 2022Thomas Munromaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1REL_15_STABLE15.11REL_14_STABLE14.16REL_13_STABLE13.19Also in: Checking pgwin32_is_junction() errors (not this thread)Also in: pg_rewind fails on Windows where tablespaces are used (not this thread)
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #20 of 1 reviewer saw the final version

The src/port/win32stat.c implementation exactly matches #2, including current-path tracking, the eight-hop limit and ELOOP; its filesystem tests were omitted #3. This supersedes the attribution in thread #45694 to the older August submission #513231, because this thread contains the latest matching patchset.

  • Roman Zharkovno review foundtrailerRoman's review credit accompanies the earlier work in thread #45694, but no review activity by him appears in this thread.
Fix readlink() for non-PostgreSQL junction points on Windows.
25 Oct 2022Thomas Munromaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1REL_15_STABLE15.11REL_14_STABLE14.16REL_13_STABLE13.19Also in: Checking pgwin32_is_junction() errors (not this thread)Also in: pg_rewind fails on Windows where tablespaces are used (not this thread)
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #20 of 1 reviewer saw the final version

The src/port/dirmod.c change exactly matches #2, restricting prefix stripping to drive-absolute paths, while its filesystem tests were omitted #3. This supersedes the attribution in thread #45694 to #513195, because the October submission here is the latest matching patchset.

  • Roman Zharkovno review foundtrailerRoman is credited in the patch and commit for earlier work in thread #45694, but no review activity by him appears in this thread.
Fix lstat() for broken junction points on Windows.
25 Oct 2022Thomas Munromaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1REL_15_STABLE15.9REL_14_STABLE14.14REL_13_STABLE13.17
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #21 of 1 reviewer saw the final version

The changes to src/port/win32stat.c and src/port/win32error.c exactly match the broken-junction lstat fix in #2. Its test additions and test cleanup changes were retained in the uncommitted remainder #3.

  • Andres Freundsaw the final versionLLM analysis, 83% sureThomas reports Andres's Windows filesystem testing, including passing ReFS tests covering the broken-junction case from #1, in #2; the committed fix retained that implementation.
Fix readlink() return value on Windows.
25 Oct 2022Thomas Munromaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1
LLM analysis, 100% suremodified before commitlight changesfrom patchset #21 of 1 reviewer saw the final version

The three-line addition to pgreadlink() in src/port/dirmod.c matches #2, subtracting the terminating byte from the returned length. The only code-diff edit changes the comment's spelling from 'nul' to 'null'.

  • Andres Freundsaw the final versionLLM analysis, 83% sureThomas reports Andres's filesystem-suite testing in #2, covering the explicit readlink-length assertion in #1, after which this fix received only a comment edit.
Fix symlink() errno on Windows.
25 Oct 2022Thomas Munromaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1
LLM analysis, 100% surelanded as postedfrom patchset #21 of 1 reviewer saw the final version

All three pgsymlink() hunks in src/port/dirmod.c match #2 exactly, mapping Windows errors and preserving errno across cleanup.

  • Andres Freundsaw the final versionLLM analysis, 83% sureThomas reports Andres's filesystem-suite testing in #2, covering symlink error assertions introduced in #1, with no subsequent changes to this fix.

Credits across 6 commits

Author
Thomas Munro5 LLM6
Alexandra Wang1
Reviewer
Zharkov Roman2
Andrew Dunstancommitter1
Michael Paquier1
Reported by
Justin Pryzby1
Zharkov Roman1
Committer
Thomas Munro6
Andrew Dunstan3

N LLM means N of the credits come from LLM analysis, not from commit trailers.