Improve tab completion for ALTER STATISTICS

Started by vignesh Cover 3 years ago3 messageshackers
Jump to latest
#1vignesh C
vignesh21@gmail.com

HI,

I noticed that the tab completion for ALTER STATISTICS .. SET was not
handled. The attached patch displays SCHEMA and STATISTICS for tab
completion of ALTER STATISTICS name SET.

Regards,
Vignesh

Attachments:

v1-0001-Tab-completion-for-ALTER-STATISTCS-name-SET.patchtext/x-patch; charset=US-ASCII; name=v1-0001-Tab-completion-for-ALTER-STATISTCS-name-SET.patchDownload+3-1
#2Michael Paquier
michael@paquier.xyz
In reply to: vignesh C (#1)
Re: Improve tab completion for ALTER STATISTICS

On Wed, Oct 19, 2022 at 04:06:51PM +0530, vignesh C wrote:

I noticed that the tab completion for ALTER STATISTICS .. SET was not
handled. The attached patch displays SCHEMA and STATISTICS for tab
completion of ALTER STATISTICS name SET.

Indeed, it is a bit strange as we would get a list of settable
parameters once the completion up to SET is done, rather than
STATISTICS and SCHEMA. Your patch looks fine, so applied. Thanks!
--
Michael

#3vignesh C
vignesh21@gmail.com
In reply to: Michael Paquier (#2)
Re: Improve tab completion for ALTER STATISTICS

On Mon, 24 Oct 2022 at 12:30, Michael Paquier <michael@paquier.xyz> wrote:

On Wed, Oct 19, 2022 at 04:06:51PM +0530, vignesh C wrote:

I noticed that the tab completion for ALTER STATISTICS .. SET was not
handled. The attached patch displays SCHEMA and STATISTICS for tab
completion of ALTER STATISTICS name SET.

Indeed, it is a bit strange as we would get a list of settable
parameters once the completion up to SET is done, rather than
STATISTICS and SCHEMA. Your patch looks fine, so applied. Thanks!

Thanks for pushing this.

Regards,
Vignesh