[PATCH] Replace "implementor" with "implementer"

Started by Aleksander Alekseevalmost 4 years ago4 messageshackers
Beta feature

Hackorum builds and tests every patch posted to the lists, not only commitfest submissions. This is Hackorum's own CI rather than the PostgreSQL project's, and it is still under testing - please report anything that looks wrong.

won't retrysuccessCI history

You can run a PostgreSQL built from this patch straight from Docker, with no checkout and no build:

docker run --rm -p 5432:5432 ghcr.io/hackorum-dev/postgres-patch:t46822
psql -h localhost -U postgres

Built from patchset v1 (message #1), July 28, 2026 at 01:52 AM.

Every patchset is also pushed to a branch of our PostgreSQL fork, so you can check out the same tree CI built. Without a PostgreSQL checkout:

git clone --branch t46822_1 https://github.com/hackorum-dev/postgres.git

In a checkout you already have, add the fork once:

git remote add hackorum https://github.com/hackorum-dev/postgres.git

then, for this patchset and every later one:

git fetch hackorum t46822_1 && git checkout t46822_1

Patchset v1 (message #1) is on t46822_1

Jump to latest
#1Aleksander Alekseev
aleksander@timescale.com

Hi hackers,

I noticed that there are several places where we use the spelling
"implementOr" while the correct one seems to be "implementEr". Here is
the patch.

--
Best regards,
Aleksander Alekseev

Attachments:

t46822_1
v1-0001-Fix-incorrect-spelling-of-the-word-implementer.patchapplication/octet-stream; name=v1-0001-Fix-incorrect-spelling-of-the-word-implementer.patchDownload+5-6
#2Aleksander Alekseev
aleksander@timescale.com
In reply to: Aleksander Alekseev (#1)
Re: [PATCH] Replace "implementor" with "implementer"

Hi hackers,

I noticed that there are several places where we use the spelling
"implementOr" while the correct one seems to be "implementEr". Here is
the patch.

After a little more study I found evidence that both spellings can be
acceptable [1]https://english.stackexchange.com/a/358111. As a non-native speaker I can't judge whether this is
true or not and which spelling is preferable. I believe we should
unify the spelling though. The reason why I initially thought
"implementOr" is an incorrect spelling is because most spell-checking
tools I personally use indicated so.

[1]: https://english.stackexchange.com/a/358111

--
Best regards,
Aleksander Alekseev

#3Tom Lane
tgl@sss.pgh.pa.us
In reply to: Aleksander Alekseev (#1)
Re: [PATCH] Replace "implementor" with "implementer"

Aleksander Alekseev <aleksander@timescale.com> writes:

I noticed that there are several places where we use the spelling
"implementOr" while the correct one seems to be "implementEr". Here is
the patch.

They're both valid according to the dictionaries I looked
at, eg [1]https://www.merriam-webster.com/dictionary/implement. I don't feel a need to change anything.

regards, tom lane

[1]: https://www.merriam-webster.com/dictionary/implement

#4Aleksander Alekseev
aleksander@timescale.com
In reply to: Tom Lane (#3)
Re: [PATCH] Replace "implementor" with "implementer"

Hi Tom,

They're both valid according to the dictionaries I looked
at, eg [1]. I don't feel a need to change anything.

OK, thanks. And sorry for the noise.

--
Best regards,
Aleksander Alekseev