bug: pg_dump use strange tag for trigger
Hackorum builds and tests every patch posted to the lists, not only commitfest submissions. This is Hackorum's own CI rather than the PostgreSQL project's, and it is still under testing - please report anything that looks wrong.
You can run a PostgreSQL built from this patch straight from Docker, with no checkout and no build:
docker run --rm -p 5432:5432 ghcr.io/hackorum-dev/postgres-patch:t46894psql -h localhost -U postgresBuilt from patchset v1 (message #1), September 20, 2026 at 11:09 AM.
Every patchset is also pushed to a branch of our PostgreSQL fork, so you can check out the same tree CI built. Without a PostgreSQL checkout:
git clone --branch t46894_1 https://github.com/hackorum-dev/postgres.gitIn a checkout you already have, add the fork once:
git remote add hackorum https://github.com/hackorum-dev/postgres.gitthen, for this patchset and every later one:
git fetch hackorum t46894_1 && git checkout t46894_1Patchset v1 (message #1) is on t46894_1
Hi,
When I played with regression tests for pg_restore, I tested -T filtering
triggers too. I had problems with restoring triggers. I found that the name
for trigger uses the pattern "tablename triggername" (not just (and
correct) triggername).
I propose to generate tag just like trigger name
proposed patch attached
regards
Pavel
Pavel Stehule <pavel.stehule@gmail.com> writes:
When I played with regression tests for pg_restore, I tested -T filtering
triggers too. I had problems with restoring triggers. I found that the name
for trigger uses the pattern "tablename triggername" (not just (and
correct) triggername).
I propose to generate tag just like trigger name
Trigger names by themselves aren't even a little bit unique, so that
doesn't seem like a great idea to me. There's backwards compatibility
to worry about, too. Maybe we need a documentation adjustment, instead?
regards, tom lane
ne 6. 11. 2022 v 15:52 odesílatel Tom Lane <tgl@sss.pgh.pa.us> napsal:
Pavel Stehule <pavel.stehule@gmail.com> writes:
When I played with regression tests for pg_restore, I tested -T filtering
triggers too. I had problems with restoring triggers. I found that thename
for trigger uses the pattern "tablename triggername" (not just (and
correct) triggername).I propose to generate tag just like trigger name
Trigger names by themselves aren't even a little bit unique, so that
doesn't seem like a great idea to me. There's backwards compatibility
to worry about, too. Maybe we need a documentation adjustment, instead?
I understand, but the space is a little bit non intuitive. Maybe use dot
there and better documentation.
Regards
Pavel
Show quoted text
regards, tom lane