Jun - Jul 2024

2 commits
Fix missing installation/uninstallation rules for BackgroundPsql.pm
1 Jul 2024Heikki LinnakangasREL_15_STABLE15.8REL_14_STABLE14.13REL_13_STABLE13.16REL_12_STABLE12.20
LLM analysis, 80% surelanded as postedfrom patchset #592 of 2 reviewers saw the final version

The commit adds the two BackgroundPsql.pm install/uninstall rules in src/test/perl/Makefile proposed by Pavan Deolasee and submitted in #59; #60 confirms they were pushed. The attachment extraction failure prevents an exact textual comparison.

  • Daniel Gustafssonsaw the final versionLLM analysis, 90% sureConfirmed Pavan's missing-installation-rule diagnosis and endorsed backporting the remedy in #58, before the equivalent attached fix in #59.
  • Heikki Linnakangassaw the final versioncommittercommitted the patch
Backport BackgroundPsql perl test module
27 Jun 2024Heikki LinnakangasREL_16_STABLE16.4REL_15_STABLE15.8REL_14_STABLE14.13REL_13_STABLE13.16REL_12_STABLE12.20
LLM analysis, 99% surewritten from the discussion, no matching patch7 of 7 reviewers saw the final version

Heikki proposed and implemented the backport without posting a corresponding patchset, choosing the replacement API described in #43 and confirmed in #56. This canonical branch diff adds timeout plumbing and fatal warnings in BackgroundPsql.pm and Cluster.pm, which do not match the attached original refactor.

  • Andres Freundsaw the final versionLLM analysis, 90% sureEndorsed backporting the facility and explained that retaining the old testing interface encourages missing or fragile tests in #45.
  • Tom Lanesaw the final versionLLM analysis, 97% sureRecommended replacing the old interface outright in #46 and questioned delaying the backport for unrelated improvements in #50.
  • Melanie Plagemansaw the final versionLLM analysis, 97% sureSupported the backport and specifically warned that skipped tests using background_psql also needed conversion in #47.
  • Andrew Dunstansaw the final versionLLM analysis, 82% sureEndorsed the proposed direction while discussing eventual replacement with a libpq-based Session object in #48.
  • Daniel Gustafssonsaw the final versionLLM analysis, 97% sureSupported replacing the old API, investigated out-of-tree compatibility, and raised outstanding timer issues for consideration in #49.
  • Alvaro Herrerasaw the final versionLLM analysis, 84% sureRecommended proceeding without waiting for the unfinished alternative Session framework in #52.
  • Robert Haassaw the final versionLLM analysis, 94% sureExplicitly endorsed the immediate backport and rejected the prospective PgFFI replacement as a reason to delay in #55.

Apr 2023

3 commits
Skip \password TAP test on old IPC::Run versions
8 Apr 2023Daniel Gustafssonmaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1
LLM analysis, 100% surewritten from the discussion, no matching patch1 of 1 reviewer saw the final version

Adds the IPC::Run >= 0.98 guard to src/test/authentication/t/001_password.pl directly from Tom Lane's version testing and recommendation in #37, accepted in #40. No attached patchset contains this additional guard.

  • Tom Lanesaw the final versionLLM analysis, 100% sureBisected the failure to IPC::Run versions before 0.98 and proposed the exact conditional skip in #36 and #37, also receiving investigation credit in the commit.
Test SCRAM iteration changes with psql \password
7 Apr 2023Daniel Gustafssonmaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1Also in: Raising the SCRAM iteration count (not this thread)
LLM analysis, 100% surelanded as postedfrom patchset #281 of 1 reviewer saw the final version

The commit exactly matches the second patch in #28, adding 26 lines to src/test/authentication/t/001_password.pl for interactive SCRAM password testing with an IO::Pty guard. Although thread #47079 claims a partial match to its older #530100, this thread supplies the latest matching patchset, so the commit belongs here under the latest-source rule.

  • Andres Freundsaw the final versionLLM analysis, 99% sureRequired skipping the password test when IO::Pty is unavailable and isolated the failures to the second patch in #23 and #24, leading to the light test adjustment in #28.
Refactor background psql TAP functions
7 Apr 2023Daniel Gustafssonmaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1
LLM analysis, 100% suremodified before commitlight changesfrom patchset #281 of 2 reviewers saw the final version

Matches the first patch in #28 with documentation, formatting, and comment polish in BackgroundPsql.pm, Cluster.pm, and 015_stream.pl; #29 confirms these finishing edits. The patch header and commit credit Andres Freund, whose original implementation is #3.

  • Andrew Dunstansaw an earlier versiontrailerReviewed class placement, constructor restrictions, return values, and timer state in #6, #8, and #14, after which query-return logic, timer handling, and parameter forwarding changed.
  • Daniel Gustafssonsaw the final versioncommittercommitted the patch

Credits across 5 commits

Author
Andres Freund1
Daniel GustafssonLLM1
Pavan Deolasee1
Reviewer
Andrew Dunstan1
Daniel Gustafssoncommitter1
Heikki Linnakangascommitter1
Committer
Daniel Gustafsson3
Heikki Linnakangas2

N LLM means N of the credits come from LLM analysis, not from commit trailers.