Remove unused code related to unknown type

Started by Peter Eisentrautalmost 3 years ago3 messages
#1Peter Eisentraut
peter.eisentraut@enterprisedb.com
1 attachment(s)

Here is a patch that removes some unused leftovers from commit
cfd9be939e9c516243c5b6a49ad1e1a9a38f1052 (old).

Attachments:

0001-Remove-unused-code-related-to-unknown-type.patchtext/plain; charset=UTF-8; name=0001-Remove-unused-code-related-to-unknown-type.patchDownload
From 638fa48b0852bf501069b4a6993454c011d9d42a Mon Sep 17 00:00:00 2001
From: Peter Eisentraut <peter@eisentraut.org>
Date: Thu, 2 Feb 2023 22:53:26 +0100
Subject: [PATCH] Remove unused code related to unknown type

These are leftovers obsoleted by
cfd9be939e9c516243c5b6a49ad1e1a9a38f1052.
---
 src/backend/utils/adt/varlena.c | 7 -------
 1 file changed, 7 deletions(-)

diff --git a/src/backend/utils/adt/varlena.c b/src/backend/utils/adt/varlena.c
index fd81c47474..170b3a3820 100644
--- a/src/backend/utils/adt/varlena.c
+++ b/src/backend/utils/adt/varlena.c
@@ -45,7 +45,6 @@
 /* GUC variable */
 int			bytea_output = BYTEA_OUTPUT_HEX;
 
-typedef struct varlena unknown;
 typedef struct varlena VarString;
 
 /*
@@ -112,12 +111,6 @@ typedef struct
  */
 #define TEXTBUFLEN		1024
 
-#define DatumGetUnknownP(X)			((unknown *) PG_DETOAST_DATUM(X))
-#define DatumGetUnknownPCopy(X)		((unknown *) PG_DETOAST_DATUM_COPY(X))
-#define PG_GETARG_UNKNOWN_P(n)		DatumGetUnknownP(PG_GETARG_DATUM(n))
-#define PG_GETARG_UNKNOWN_P_COPY(n) DatumGetUnknownPCopy(PG_GETARG_DATUM(n))
-#define PG_RETURN_UNKNOWN_P(x)		PG_RETURN_POINTER(x)
-
 #define DatumGetVarStringP(X)		((VarString *) PG_DETOAST_DATUM(X))
 #define DatumGetVarStringPP(X)		((VarString *) PG_DETOAST_DATUM_PACKED(X))
 
-- 
2.39.1

#2Tom Lane
tgl@sss.pgh.pa.us
In reply to: Peter Eisentraut (#1)
Re: Remove unused code related to unknown type

Peter Eisentraut <peter.eisentraut@enterprisedb.com> writes:

Here is a patch that removes some unused leftovers from commit
cfd9be939e9c516243c5b6a49ad1e1a9a38f1052 (old).

Ugh. Those are outright wrong now, aren't they? Better nuke 'em.

regards, tom lane

#3Peter Eisentraut
peter.eisentraut@enterprisedb.com
In reply to: Tom Lane (#2)
Re: Remove unused code related to unknown type

On 03.02.23 00:12, Tom Lane wrote:

Peter Eisentraut <peter.eisentraut@enterprisedb.com> writes:

Here is a patch that removes some unused leftovers from commit
cfd9be939e9c516243c5b6a49ad1e1a9a38f1052 (old).

Ugh. Those are outright wrong now, aren't they? Better nuke 'em.

done