gokiburi versus the back branches

Started by Tom Laneabout 3 years ago3 messageshackers
Jump to latest
#1Tom Lane
tgl@sss.pgh.pa.us

I notice that Michael's new BF animal gokiburi is failing in
all the pre-v15 branches, though it's fine in v15 and HEAD.
It's evidently dying from ASLR effects because it's trying
to build with EXEC_BACKEND on Linux: there's lots of

2023-02-06 06:07:02.131 GMT [1503972] FATAL: could not reattach to shared memory (key=813803, addr=0xffff8c3a5000): Invalid argument
2023-02-06 06:07:02.131 GMT [1503971] FATAL: could not reattach to shared memory (key=813803, addr=0xffff8c3a5000): Invalid argument
2023-02-06 06:07:02.132 GMT [1503976] FATAL: could not reattach to shared memory (key=813803, addr=0xffff8c3a5000): Invalid argument

in its logs.

The reason it's okay in v15 and up is presumably this:

Author: Thomas Munro <tmunro@postgresql.org>
Branch: master Release: REL_15_BR [f3e78069d] 2022-01-11 00:04:33 +1300

Make EXEC_BACKEND more convenient on Linux and FreeBSD.

Try to disable ASLR when building in EXEC_BACKEND mode, to avoid random
memory mapping failures while testing. For developer use only, no
effect on regular builds.

Is it time to back-patch that commit? The alternative would be
to run the animal with an ASLR-disabling environment variable.
On the whole I think testing that f3e78069d works is more
useful than working around lack of it.

regards, tom lane

#2Michael Paquier
michael@paquier.xyz
In reply to: Tom Lane (#1)
Re: gokiburi versus the back branches

On Mon, Feb 06, 2023 at 06:27:50PM -0500, Tom Lane wrote:

Is it time to back-patch that commit? The alternative would be
to run the animal with an ASLR-disabling environment variable.
On the whole I think testing that f3e78069d works is more
useful than working around lack of it.

Yes, this is my intention as of this message from last week, once this
week's release is tagged:
/messages/by-id/Y9sMhxo51HRXAmtu@paquier.xyz

Thanks,
--
Michael

#3Tom Lane
tgl@sss.pgh.pa.us
In reply to: Michael Paquier (#2)
Re: gokiburi versus the back branches

Michael Paquier <michael@paquier.xyz> writes:

On Mon, Feb 06, 2023 at 06:27:50PM -0500, Tom Lane wrote:

Is it time to back-patch that commit?

Yes, this is my intention as of this message from last week, once this
week's release is tagged:
/messages/by-id/Y9sMhxo51HRXAmtu@paquier.xyz

D'oh, I'd totally forgotten that conversation already :-(

regards, tom lane