Missing default value of createrole_self_grant in document

Started by shiy.fnst@fujitsu.comalmost 3 years ago2 messages
#1shiy.fnst@fujitsu.com
shiy.fnst@fujitsu.com
1 attachment(s)

Hi hackers,

I noticed that the document of GUC createrole_self_grant doesn't mention its
default value. The attached patch adds that.

Regards,
Shi Yu

Attachments:

v1-0001-Add-default-value-of-createrole_self_grant-in-doc.patchapplication/octet-stream; name=v1-0001-Add-default-value-of-createrole_self_grant-in-doc.patchDownload
From e1c64376c464e7da22171f0e0e3a7f44309eccff Mon Sep 17 00:00:00 2001
From: Shi Yu <shiy.fnst@fujitsu.com>
Date: Thu, 16 Feb 2023 17:19:24 +0800
Subject: [PATCH v1] Add default value of createrole_self_grant in document

---
 doc/src/sgml/config.sgml | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/doc/src/sgml/config.sgml b/doc/src/sgml/config.sgml
index ecd9aa73ef..e5c41cc6c6 100644
--- a/doc/src/sgml/config.sgml
+++ b/doc/src/sgml/config.sgml
@@ -9499,7 +9499,8 @@ SET XML OPTION { DOCUMENT | CONTENT };
         is set to a non-empty value, the newly-created role will be granted
         to the creating user with the options specified. The value must be
         <literal>set</literal>, <literal>inherit</literal>, or a
-        comma-separated list of these.
+        comma-separated list of these. The default value is an empty string,
+        which disables the feature.
        </para>
        <para>
         The purpose of this option is to allow a <literal>CREATEROLE</literal>
-- 
2.30.0.windows.2

#2Daniel Gustafsson
daniel@yesql.se
In reply to: shiy.fnst@fujitsu.com (#1)
Re: Missing default value of createrole_self_grant in document

On 16 Feb 2023, at 10:47, shiy.fnst@fujitsu.com wrote:

I noticed that the document of GUC createrole_self_grant doesn't mention its
default value. The attached patch adds that.

Agreed, showing the default value in the documentation is a good pattern IMO.
Unless objected to I'll go apply this in a bit.

--
Daniel Gustafsson