Missing rules for queryjumblefuncs.{funcs,switch}.c for maintainer-clean

On Mon, Mar 20, 2023 at 2:43 PM Michael Paquier <michael@paquier.xyz> wrote:

Nathan has reported to me offlist that maintainer-clean was not doing
its job for the files generated by gen_node_support.pl in
src/backend/nodes/ for the query jumbling. Attached is a patch to
take care of this issue.

While on it, I have found a comment in the related README that was
missing a refresh.

Any objections or comments?

A minor comment for the README is that now we have five support
functions not four.

- outcome.  (For some classes of node types, you don't need all four support
+ outcome.  (For some classes of node types, you don't need all five support

Thanks
Richard

On Mon, Mar 20, 2023 at 03:18:17PM +0800, Richard Guo wrote:

A minor comment for the README is that now we have five support
functions not four.

- outcome.  (For some classes of node types, you don't need all four support
+ outcome.  (For some classes of node types, you don't need all five support

Right, missed that. How about removing the "fout/five" entirely here
and make that simpler? I would propose:
"For some classes of node types, you don't need all the support
functions."
--
Michael

On 20 Mar 2023, at 08:46, Michael Paquier <michael@paquier.xyz> wrote:

How about removing the "fout/five" entirely here
and make that simpler? I would propose:
"For some classes of node types, you don't need all the support
functions."

Yes please, keeping such counts in sync is always error-prone.

--
Daniel Gustafsson

On Mon, Mar 20, 2023 at 3:49 PM Daniel Gustafsson <daniel@yesql.se> wrote:

On 20 Mar 2023, at 08:46, Michael Paquier <michael@paquier.xyz> wrote:
How about removing the "fout/five" entirely here
and make that simpler? I would propose:
"For some classes of node types, you don't need all the support
functions."

Yes please, keeping such counts in sync is always error-prone.

Agreed. +1 to remove the counts.

Thanks
Richard

Michael Paquier <michael@paquier.xyz> writes:

Nathan has reported to me offlist that maintainer-clean was not doing
its job for the files generated by gen_node_support.pl in
src/backend/nodes/ for the query jumbling. Attached is a patch to
take care of this issue.
While on it, I have found a comment in the related README that was
missing a refresh.
Any objections or comments?

Is similar knowledge missing in the meson build files?

regards, tom lane

On Mon, Mar 20, 2023 at 10:21:28AM -0400, Tom Lane wrote:

Is similar knowledge missing in the meson build files?

src/backend/nodes/meson.build and src/include/nodes/meson.build are
the two meson files that have the knowledge about the files generated
by gen_node_support.pl, and the query jumbling files are consistent
with that since 0e681cf. Perhaps I've missed an extra spot?
--
Michael

On Mon, Mar 20, 2023 at 04:04:31PM +0800, Richard Guo wrote:

Agreed. +1 to remove the counts.

Thanks. Adjusted this way, then.
--
Michael