pg_basebackup: Correct type of WalSegSz
Started by Peter Eisentrautabout 3 years ago2 messageshackers
The pg_basebackup code has WalSegSz as uint32, whereas the rest of the
code has it as int. This seems confusing, and using the extra range
wouldn't actually work. This was in the original commit (fc49e24fa6),
but I suppose it was an oversight.
Attachments:
0001-pg_basebackup-Correct-type-of-WalSegSz.patchtext/plain; charset=UTF-8; name=0001-pg_basebackup-Correct-type-of-WalSegSz.patchDownload+2-3
Re: pg_basebackup: Correct type of WalSegSz
On 30 Mar 2023, at 08:24, Peter Eisentraut <peter.eisentraut@enterprisedb.com> wrote:
The pg_basebackup code has WalSegSz as uint32, whereas the rest of the code has it as int. This seems confusing, and using the extra range wouldn't actually work. This was in the original commit (fc49e24fa6), but I suppose it was an oversight.
LGTM, it indeed seems to be an accidental oversight.
--
Daniel Gustafsson