check_GUC_init(wal_writer_flush_after) fails with non-default block size
Hi,
If you build with --with-wal-blocksize=/-Dwal_blocksize= anything but
8, this breaks:
running bootstrap script ... LOG: GUC (PGC_INT)
wal_writer_flush_after, boot_val=256, C-var=128
TRAP: failed Assert("check_GUC_init(hentry->gucvar)"), File: "guc.c",
Line: 1519, PID: 84605
Attachments:
0001-Fix-default-wal_writer_flush_after-value.patchtext/x-patch; charset=US-ASCII; name=0001-Fix-default-wal_writer_flush_after-value.patchDownload+4-3
Hi,
On 2023-04-08 13:18:55 +1200, Thomas Munro wrote:
If you build with --with-wal-blocksize=/-Dwal_blocksize= anything but
8, this breaks:running bootstrap script ... LOG: GUC (PGC_INT)
wal_writer_flush_after, boot_val=256, C-var=128
TRAP: failed Assert("check_GUC_init(hentry->gucvar)"), File: "guc.c",
Line: 1519, PID: 84605
From 48d971e0b19f770991e334b8dc38422462b4485e Mon Sep 17 00:00:00 2001
From: Thomas Munro <thomas.munro@gmail.com>
Date: Sat, 8 Apr 2023 13:12:48 +1200
Subject: [PATCH] Fix default wal_writer_flush_after value.
LGTM.
Greetings,
Andres
On Sat, Apr 8, 2023 at 5:21 PM Andres Freund <andres@anarazel.de> wrote:
On 2023-04-08 13:18:55 +1200, Thomas Munro wrote:
Subject: [PATCH] Fix default wal_writer_flush_after value.
LGTM.
Thanks, pushed.
On Mon, May 15, 2023 at 11:26:31AM +1200, Thomas Munro wrote:
On Sat, Apr 8, 2023 at 5:21 PM Andres Freund <andres@anarazel.de> wrote:
On 2023-04-08 13:18:55 +1200, Thomas Munro wrote:
Subject: [PATCH] Fix default wal_writer_flush_after value.
LGTM.
Thanks, pushed.
Somewhat forgot about this thread. Thanks for the fix!
--
Michael