RelationGetIndexAttrBitmap comment outdated
Hackorum builds and tests every patch posted to the lists, not only commitfest submissions. This is Hackorum's own CI rather than the PostgreSQL project's, and it is still under testing - please report anything that looks wrong.
You can run a PostgreSQL built from this patch straight from Docker, with no checkout and no build:
docker run --rm -p 5432:5432 ghcr.io/hackorum-dev/postgres-patch:t48153psql -h localhost -U postgresBuilt from patchset v1 (message #1), July 28, 2026 at 12:29 AM.
Every patchset is also pushed to a branch of our PostgreSQL fork, so you can check out the same tree CI built. Without a PostgreSQL checkout:
git clone --branch t48153_1 https://github.com/hackorum-dev/postgres.gitIn a checkout you already have, add the fork once:
git remote add hackorum https://github.com/hackorum-dev/postgres.gitthen, for this patchset and every later one:
git fetch hackorum t48153_1 && git checkout t48153_1Patchset v1 (message #1) is on t48153_1
I realized that commit 19d8e2308bc5 (and 5753d4ee320b before that) added
a new output type to RelationGetIndexAttrBitmap but forgot to list its
effect in the function's documenting comment. Here's a patch that
updates it, making it more specific (and IMO more readable). I also add
a comment to the enum definition, to remind people that the other one
needs to be modified.
This ought to be backpatched to 16.
--
Álvaro Herrera Breisgau, Deutschland — https://www.EnterpriseDB.com/
"La conclusión que podemos sacar de esos estudios es que
no podemos sacar ninguna conclusión de ellos" (Tanenbaum)
On 12 Jul 2023, at 16:37, Alvaro Herrera <alvherre@alvh.no-ip.org> wrote:
I realized that commit 19d8e2308bc5 (and 5753d4ee320b before that) added
a new output type to RelationGetIndexAttrBitmap but forgot to list its
effect in the function's documenting comment. Here's a patch that
updates it, making it more specific (and IMO more readable). I also add
a comment to the enum definition, to remind people that the other one
needs to be modified.
LGTM, a clear improvement.
This ought to be backpatched to 16.
+1
--
Daniel Gustafsson