Apr 2024

2 commits
Remove references to old function name
8 Apr 2024Andres Freundmaster17beta1REL_19_STABLE17beta1REL_18_STABLE17beta1REL_17_STABLE17beta1Also in: pgsql: Reduce branches in heapgetpage()'s per-tuple loop (not this thread)
LLM analysis, 99% suremodified before commitlight changesfrom patchset #141 of 1 reviewer saw the final version

Implements the helper rename and comment correction from #14 in src/backend/access/heap/heapam.c, choosing page_collect_tuples() instead of heap_prepare_pagescan_tuples() and retaining shorter formatting. Andres proposed the final name in #17, and David accepted it in #18.

  • Andres Freundsaw the final versioncommittercommitted the patch
Reduce branches in heapgetpage()'s per-tuple loop
7 Apr 2024Andres Freundmaster17beta1REL_19_STABLE17beta1REL_18_STABLE17beta1REL_17_STABLE17beta1Also in: Improving the heapgetpage function improves performance in common scenarios (not this thread)
LLM analysis, 100% suremodified before commitlight changesfrom patchset #112 of 2 reviewers saw the final version

The commit matches #11 in src/backend/access/heap/heapam.c with only declaration reordering, a rewritten constant-folding comment, and added credits. The matching April 2024 patchset is newer than the August 2023 alternative in thread #48340; that thread's from_discussion verdict misattributes provenance, although its evidence correctly identifies Andres's implementation as the source and the other thread's contribution as testing.

  • John Naylorsaw the final versiontrailerJohn tested the combined-call alternative and requested true/false arguments in #6, confirmed failed constant folding in #8, and only a rebase and light edits followed.
  • Zhang Minglisaw the final versiontrailerZhang reviewed the four specialized calls and proposed combining them in #2, with the committed version retaining the reviewed design through a rebase and light edits.

Credits across 2 commits

Author
Andres FreundLLM1
David RowleyLLM1
Reviewer
Andres Freundcommitter1
John Naylor1
Zhang Mingli1
Tested by
Quan Zongliang1
Reported by
David Rowley1
Melanie Plageman1
Committer
Andres Freund2

N LLM means N of the credits come from LLM analysis, not from commit trailers.