Standardize spelling of "power of two"
Hello.
pg_resetwal and initdb has an error message like this:
msgid "argument of --wal-segsize must be a power of 2 between 1 and 1024"
In other parts in the tree, however, we spell it as "power of two". I
think it would make sense to standardize the spelling for
consistency. See the attached.
regards.
--
Kyotaro Horiguchi
NTT Open Source Software Center
Attachments:
standardize_spelling_of_power_of_two.patchtext/x-patch; charset=us-asciiDownload
diff --git a/src/bin/initdb/initdb.c b/src/bin/initdb/initdb.c
index c66467eb95..905b979947 100644
--- a/src/bin/initdb/initdb.c
+++ b/src/bin/initdb/initdb.c
@@ -3350,7 +3350,7 @@ main(int argc, char *argv[])
check_need_password(authmethodlocal, authmethodhost);
if (!IsValidWalSegSize(wal_segment_size_mb * 1024 * 1024))
- pg_fatal("argument of %s must be a power of 2 between 1 and 1024", "--wal-segsize");
+ pg_fatal("argument of %s must be a power of two between 1 and 1024", "--wal-segsize");
get_restricted_token();
diff --git a/src/bin/pg_resetwal/pg_resetwal.c b/src/bin/pg_resetwal/pg_resetwal.c
index 9bebc2a995..25ecdaaa15 100644
--- a/src/bin/pg_resetwal/pg_resetwal.c
+++ b/src/bin/pg_resetwal/pg_resetwal.c
@@ -298,7 +298,7 @@ main(int argc, char *argv[])
exit(1);
set_wal_segsize = wal_segsize_mb * 1024 * 1024;
if (!IsValidWalSegSize(set_wal_segsize))
- pg_fatal("argument of %s must be a power of 2 between 1 and 1024", "--wal-segsize");
+ pg_fatal("argument of %s must be a power of two between 1 and 1024", "--wal-segsize");
break;
}
On 29 Aug 2023, at 10:56, Kyotaro Horiguchi <horikyota.ntt@gmail.com> wrote:
pg_resetwal and initdb has an error message like this:
msgid "argument of --wal-segsize must be a power of 2 between 1 and 1024"
In other parts in the tree, however, we spell it as "power of two". I
think it would make sense to standardize the spelling for
consistency. See the attached.
Agreed. While we have numerous "power of 2" these were the only ones in
translated user-facing messages, so I've pushed this to master (it didn't seem
worth disrupting translations for 16 as we are so close to wrapping it, if
others disagree I can backpatch).
--
Daniel Gustafsson
On 2023-Aug-29, Daniel Gustafsson wrote:
Agreed. While we have numerous "power of 2" these were the only ones
in translated user-facing messages, so I've pushed this to master (it
didn't seem worth disrupting translations for 16 as we are so close to
wrapping it, if others disagree I can backpatch).
I'd rather backpatch it. There's only 5 translations that are 100% for
initdb.po, and they have two weeks to make the change from "2" to "two".
I don't think this is a problem.
--
Álvaro Herrera Breisgau, Deutschland — https://www.EnterpriseDB.com/
On 29 Aug 2023, at 13:11, Alvaro Herrera <alvherre@alvh.no-ip.org> wrote:
On 2023-Aug-29, Daniel Gustafsson wrote:
Agreed. While we have numerous "power of 2" these were the only ones
in translated user-facing messages, so I've pushed this to master (it
didn't seem worth disrupting translations for 16 as we are so close to
wrapping it, if others disagree I can backpatch).I'd rather backpatch it. There's only 5 translations that are 100% for
initdb.po, and they have two weeks to make the change from "2" to "two".
I don't think this is a problem.
Fair enough, backpatched to v16.
--
Daniel Gustafsson
At Tue, 29 Aug 2023 14:39:42 +0200, Daniel Gustafsson <daniel@yesql.se> wrote in
On 29 Aug 2023, at 13:11, Alvaro Herrera <alvherre@alvh.no-ip.org> wrote:
On 2023-Aug-29, Daniel Gustafsson wrote:
Agreed. While we have numerous "power of 2" these were the only ones
in translated user-facing messages, so I've pushed this to master (it
didn't seem worth disrupting translations for 16 as we are so close to
wrapping it, if others disagree I can backpatch).I'd rather backpatch it. There's only 5 translations that are 100% for
initdb.po, and they have two weeks to make the change from "2" to "two".
I don't think this is a problem.Fair enough, backpatched to v16.
Thank you for committing this.
regards.
--
Kyotaro Horiguchi
NTT Open Source Software Center