Add const qualifiers

On 9/1/23 11:39, David Steele wrote:

Hackers,

I noticed that there was a mismatch between the const qualifiers for
excludeDirContents in src/backend/backup/backup/basebackup.c and
src/bin/pg_rewind/file_map.c and that led me to use ^static const.*\*.*=
to do a quick search for similar cases.

I think at the least we should make excludeDirContents match, but the
rest of the changes seem like a good idea as well.

Added to 2023-11 CF.

Regards,
-David

On 09.09.23 21:03, David Steele wrote:

On 9/1/23 11:39, David Steele wrote:

Hackers,

I noticed that there was a mismatch between the const qualifiers for
excludeDirContents in src/backend/backup/backup/basebackup.c and
src/bin/pg_rewind/file_map.c and that led me to use ^static
const.*\*.*= to do a quick search for similar cases.

I think at the least we should make excludeDirContents match, but the
rest of the changes seem like a good idea as well.

Added to 2023-11 CF.

committed

On 9/26/23 06:34, Peter Eisentraut wrote:

On 09.09.23 21:03, David Steele wrote:

On 9/1/23 11:39, David Steele wrote:

Hackers,

I noticed that there was a mismatch between the const qualifiers for
excludeDirContents in src/backend/backup/backup/basebackup.c and
src/bin/pg_rewind/file_map.c and that led me to use ^static
const.*\*.*= to do a quick search for similar cases.

I think at the least we should make excludeDirContents match, but the
rest of the changes seem like a good idea as well.

Added to 2023-11 CF.

committed

Thank you, Peter!