Doc: vcregress .bat commands list lacks "taptest"

Started by Yugo NAGATAover 2 years ago6 messages

nagata@sraoss.co.jp

over 2 years ago

1 attachment(s)

Hi,

I found that "taptest" is missing in vcregress.bat command list in the
documentation when I tested psql and pgbench on Windows. I know there
is a plan to remove MSVC scripts[1]/messages/by-id/ZQzp_VMJcerM1Cs_@paquier.xyz, but is it worth adding one line
to the list for now?

[1]: /messages/by-id/ZQzp_VMJcerM1Cs_@paquier.xyz

I attached a patch for this case.

Regards,
Yugo Nagata

--
Yugo NAGATA <nagata@sraoss.co.jp>

Attachments:

doc_install-windows_taptest.patchtext/x-diff; name=doc_install-windows_taptest.patchDownload

diff --git a/doc/src/sgml/install-windows.sgml b/doc/src/sgml/install-windows.sgml
index 379a2ea80b..435a91228a 100644
--- a/doc/src/sgml/install-windows.sgml
+++ b/doc/src/sgml/install-windows.sgml
@@ -463,6 +463,7 @@ $ENV{CONFIG}="Debug";
 <userinput>vcregress isolationcheck</userinput>
 <userinput>vcregress bincheck</userinput>
 <userinput>vcregress recoverycheck</userinput>
+<userinput>vcregress taptest</userinput>
 </screen>
 
    To change the schedule used (default is parallel), append it to the
@@ -477,8 +478,9 @@ $ENV{CONFIG}="Debug";
 
   <para>
    Running the regression tests on client programs, with
-   <command>vcregress bincheck</command>, or on recovery tests, with
-   <command>vcregress recoverycheck</command>, requires an additional Perl module
+   <command>vcregress bincheck</command>, on recovery tests, with
+   <command>vcregress recoverycheck</command>, or TAP tests specified with
+   <command>vcregress taptest</command> requires an additional Perl module
    to be installed:
    <variablelist>
     <varlistentry>

Michael Paquier

michael@paquier.xyz

over 2 years ago

In reply to: Yugo NAGATA (#1)

Re: Doc: vcregress .bat commands list lacks "taptest"

On Mon, Sep 25, 2023 at 03:32:04PM +0900, Yugo NAGATA wrote:

I found that "taptest" is missing in vcregress.bat command list in the
documentation when I tested psql and pgbench on Windows. I know there
is a plan to remove MSVC scripts[1], but is it worth adding one line
to the list for now?

[1] /messages/by-id/ZQzp_VMJcerM1Cs_@paquier.xyz

I attached a patch for this case.

Assuming that the MSVC scripts are gone in v17, and assuming that your
suggestion is backpatched, it would still be useful for 5 years until
v16 is EOL'd. So I would say yes, but with a backpatch.
--
Michael