Extra periods in pg_dump messages
Sorry for the sequential mails.
In the bleeding-edge version of pg_dump, when a conditionspecifying an
index, for example, is described in an object filter file, the
following message is output. However, there is a period at the end of
the line. Shouldn't this be removed?
$ pg_dump --filter=/tmp/hoge.filter
pg_dump: error: invalid format in filter read from "/tmp/hoge.filter" on line 1: include filter for "index" is not allowed.
The attached patch includes modifications related to the calls to
pg_log_filter_error().
regards.
--
Kyotaro Horiguchi
NTT Open Source Software Center
Attachments:
remove_period_from_messages_to_pg_log_filter_error.difftext/x-patch; charset=us-asciiDownload+6-6
On 30 Nov 2023, at 02:39, Kyotaro Horiguchi <horikyota.ntt@gmail.com> wrote:
In the bleeding-edge version of pg_dump, when a conditionspecifying an
index, for example, is described in an object filter file, the
following message is output. However, there is a period at the end of
the line. Shouldn't this be removed?
Yes, ending with a period is for detail and hint messages. Fixed.
--
Daniel Gustafsson