Mar 2024

5 commits
Make RangeTblEntry dump order consistent
22 Mar 2024Peter Eisentrautmaster17beta1REL_19_STABLE17beta1REL_18_STABLE17beta1REL_17_STABLE17beta1
LLM analysis, 100% suremodified before commitlight changesfrom patchset #71 of 1 reviewer saw the final version

Matches the fifth patch in #7, moving alias and eref forward in src/include/nodes/parsenodes.h and removing redundant read/write comments. The commit additionally bumps src/include/catalog/catversion.h, completing the attachment's TODO.

  • Andrew Dunstansaw the final versiontrailerAndrew said the first five patches in #7 looked good in #8; only the catalog-version bump followed for this patch.
Remove custom _jumbleRangeTblEntry()
22 Mar 2024Peter Eisentrautmaster17beta1REL_19_STABLE17beta1REL_18_STABLE17beta1REL_17_STABLE17beta1
LLM analysis, 99% surelanded as postedfrom patchset #71 of 1 reviewer saw the final version

The diff matches the fourth patch in #7 modulo rebase offsets: it deletes _jumbleRangeTblEntry() from src/backend/nodes/queryjumblefuncs.c and adds query_jumble_ignore annotations in src/include/nodes/parsenodes.h.

  • Andrew Dunstansaw the final versiontrailerAndrew explicitly approved the first five patches of #7, including the jumbling change, in #8.
Reformat some node comments
22 Mar 2024Peter Eisentrautmaster17beta1REL_19_STABLE17beta1REL_18_STABLE17beta1REL_17_STABLE17beta1
LLM analysis, 100% surelanded as postedfrom patchset #71 of 1 reviewer saw the final version

Matches the third patch in #7 modulo rebase offsets, reformatting RangeTblEntry field comments in src/include/nodes/parsenodes.h to make room for annotations.

  • Andrew Dunstansaw the final versiontrailerAndrew said the first five patches of #7, including comment reformatting, looked good in #8.
Improve comment
22 Mar 2024Peter Eisentrautmaster17beta1REL_19_STABLE17beta1REL_18_STABLE17beta1REL_17_STABLE17beta1
LLM analysis, 100% surelanded as postedfrom patchset #71 of 1 reviewer saw the final version

Matches the second patch in #7, changing the RangeTblEntry.lateral comment in src/include/nodes/parsenodes.h to clarify that it records whether LATERAL was specified.

  • Andrew Dunstansaw the final versiontrailerAndrew's review in #8 explicitly covered the first five patches of #7, including the lateral comment.
Remove obsolete comment
22 Mar 2024Peter Eisentrautmaster17beta1REL_19_STABLE17beta1REL_18_STABLE17beta1REL_17_STABLE17beta1
LLM analysis, 100% surelanded as postedfrom patchset #71 of 1 reviewer saw the final version

Matches the first patch in #7, deleting the obsolete six-line proposal to use a union for RangeTblEntry fields from src/include/nodes/parsenodes.h.

  • Andrew Dunstansaw the final versiontrailerAndrew's approval of the first five patches in #8 covered this comment removal from #7.

Feb 2024

1 commit
Remove custom Constraint node read/write implementations
22 Feb 2024Peter Eisentrautmaster17beta1REL_19_STABLE17beta1REL_18_STABLE17beta1REL_17_STABLE17beta1
LLM analysis, 99% surelanded as postedfrom patchset #31 of 1 reviewer saw the final version

Matches the first patch in #3, removing custom Constraint serialization and reorganizing its field documentation. Differences are rebase adjustments for the without_overlaps field already present in the commit's parent, including four additional lines removed with the obsolete read/write functions.

  • Paul Jungwirthsaw the final versiontrailerPaul reported compiling and passing tests after every patch in #3, endorsed the approach, and supplied comment feedback in #4.

Credits across 6 commits

Author
Peter EisentrautLLM6
Reviewer
Andrew Dunstan5
Paul A Jungwirth1
Committer
Peter Eisentraut6

N LLM means N of the credits come from LLM analysis, not from commit trailers.