Fix copy and paste error (src/bin/pg_basebackup/pg_basebackup.c)

Started by Ranier Vilelaover 2 years ago3 messageshackers
Beta feature

Hackorum builds and tests every patch posted to the lists, not only commitfest submissions. This is Hackorum's own CI rather than the PostgreSQL project's, and it is still under testing - please report anything that looks wrong.

never appliedCI history
Jump to latest
#1Ranier Vilela
ranier.vf@gmail.com

Hi,

Per Coverity.

The function StartLogStreamer in (src/bin/pg_basebackup/pg_basebackup.c)
Has a copy and paste error.

The commit affected is dc212340058b4e7ecfc5a7a81ec50e7a207bf288
<http://dc21234&gt;

Trivial patch attached.

Best regards,
Ranier Vilela

Attachments:

fix-copy-and-paste-error-pg_basebackup.patchapplication/octet-stream; name=fix-copy-and-paste-error-pg_basebackup.patchDownload+1-1
#2Jelte Fennema-Nio
postgres@jeltef.nl
In reply to: Ranier Vilela (#1)
Re: Fix copy and paste error (src/bin/pg_basebackup/pg_basebackup.c)

On Sat, 30 Dec 2023 at 12:44, Ranier Vilela <ranier.vf@gmail.com> wrote:

The function StartLogStreamer in (src/bin/pg_basebackup/pg_basebackup.c)
Has a copy and paste error.

Nice catch. Patch looks good to me.

#3Michael Paquier
michael@paquier.xyz
In reply to: Jelte Fennema-Nio (#2)
Re: Fix copy and paste error (src/bin/pg_basebackup/pg_basebackup.c)

On Sat, Dec 30, 2023 at 01:38:00PM +0100, Jelte Fennema-Nio wrote:

On Sat, 30 Dec 2023 at 12:44, Ranier Vilela <ranier.vf@gmail.com> wrote:

The function StartLogStreamer in (src/bin/pg_basebackup/pg_basebackup.c)
Has a copy and paste error.

Nice catch. Patch looks good to me.

Please see my reply here:
/messages/by-id/ZZCzaZG7Y0Ld9ytp@paquier.xyz

So these will likely be handled in a single batch.
--
Michael