pg_dump: Remove obsolete trigger support
In 30e7c175b81, support for pre-9.2 servers was removed from pg_dump.
But I found that a lot of dead code was left for supporting dumping
triggers from those old versions, presumably because that code was not
behind straightforward versioned "if" branches. This patch removes the
rest of the unneeded code.
Attachments:
0001-pg_dump-Remove-obsolete-trigger-support.patchtext/plain; charset=UTF-8; name=0001-pg_dump-Remove-obsolete-trigger-support.patchDownload+2-203
Peter Eisentraut <peter@eisentraut.org> writes:
In 30e7c175b81, support for pre-9.2 servers was removed from pg_dump.
But I found that a lot of dead code was left for supporting dumping
triggers from those old versions, presumably because that code was not
behind straightforward versioned "if" branches. This patch removes the
rest of the unneeded code.
Hm, you're right, we can depend on pg_get_triggerdef in all cases now.
However, the patch looks a little incomplete: you did not remove
fetching of all of the now-unneeded values from the SQL queries.
regards, tom lane
On 09.01.24 16:27, Tom Lane wrote:
Peter Eisentraut <peter@eisentraut.org> writes:
In 30e7c175b81, support for pre-9.2 servers was removed from pg_dump.
But I found that a lot of dead code was left for supporting dumping
triggers from those old versions, presumably because that code was not
behind straightforward versioned "if" branches. This patch removes the
rest of the unneeded code.Hm, you're right, we can depend on pg_get_triggerdef in all cases now.
However, the patch looks a little incomplete: you did not remove
fetching of all of the now-unneeded values from the SQL queries.
I think all the remaining SQL queries only select the fields that are
needed. The now-unneeded values were only selected by queries that are
being deleted. If I missed something, an example would help me.