Patch to support transactions with BLOBs for current CVS
Hello,
here it is as requested by Bruce.
I tested it restoring my database with > 100000 BLOBS, and dumping it out.
But unfortunatly I can not restore it back due to problems in pg_dump.
--
Sincerely Yours,
Denis Perchine
----------------------------------
E-Mail: dyp@perchine.com
HomePage: http://www.perchine.com/dyp/
FidoNet: 2:5000/120.5
----------------------------------
Attachments:
here it is as requested by Bruce.
I tested it restoring my database with > 100000 BLOBS, and dumping it out.
But unfortunatly I can not restore it back due to problems in pg_dump.Please clarify - based on your last private email you stated that there was
not a problem with pg_dump, but a problem in the your BLOB patch:
Yeps. I have fixed all the crap. And it restores perfect from my archive
which I made some time ago with your pg_dump for 7.0.2. It was _10 if I am
not mistaken.
Also it dumps out fine, but restore back from new archive stops right away.
And when I tried to do dump/restore on the empty database I was failed.
From: Denis Perchine <dyp@perchine.com>
Date: Fri, 20 Oct 2000 12:15:18 +0700Sorry... I had a look inside server log... Looks like my bug...
Are you now saying there is a new problem with pg_dump?
----------------------------------------------------------------
Philip Warner | __---_____
Albatross Consulting Pty. Ltd. |----/ - \
(A.B.N. 75 008 659 498) | /(@) ______---_
Tel: (+61) 0500 83 82 81 | _________ \
Fax: (+61) 0500 83 82 82 | ___________ |
Http://www.rhyme.com.au | / \|| --________--
PGP key available upon request, | /
and from pgp5.ai.mit.edu:11371 |/
--
Sincerely Yours,
Denis Perchine
----------------------------------
E-Mail: dyp@perchine.com
HomePage: http://www.perchine.com/dyp/
FidoNet: 2:5000/120.5
----------------------------------
Import Notes
Reply to msg id not found: 3.0.5.32.20001021222156.03205ae0@mail.rhyme.com.auReference msg id not found: 3.0.5.32.20001021222156.03205ae0@mail.rhyme.com.au | Resolved by subject fallback
Yeps. I have fixed all the crap. And it restores perfect from my archive
which I made some time ago with your pg_dump for 7.0.2. It was _10 if I am
not mistaken.Also it dumps out fine, but restore back from new archive stops right
away. And when I tried to do dump/restore on the empty database I was
failed.This is the same recent bug as from the hacker list?
Yeps. I just made a comment that I was unable to make a complete circle in my
tests. :-)))
--
Sincerely Yours,
Denis Perchine
----------------------------------
E-Mail: dyp@perchine.com
HomePage: http://www.perchine.com/dyp/
FidoNet: 2:5000/120.5
----------------------------------
Import Notes
Reply to msg id not found: 3.0.5.32.20001021223505.01d71730@mail.rhyme.com.auReference msg id not found: 3.0.5.32.20001021222156.03205ae0@mail.rhyme.com.auReference msg id not found: 3.0.5.32.20001021223505.01d71730@mail.rhyme.com.au | Resolved by subject fallback
At 18:19 21/10/00 +0700, Denis Perchine wrote:
Hello,
here it is as requested by Bruce.
I tested it restoring my database with > 100000 BLOBS, and dumping it out.
But unfortunatly I can not restore it back due to problems in pg_dump.
Please clarify - based on your last private email you stated that there was
not a problem with pg_dump, but a problem in the your BLOB patch:
From: Denis Perchine <dyp@perchine.com>
Date: Fri, 20 Oct 2000 12:15:18 +0700Sorry... I had a look inside server log... Looks like my bug...
Are you now saying there is a new problem with pg_dump?
----------------------------------------------------------------
Philip Warner | __---_____
Albatross Consulting Pty. Ltd. |----/ - \
(A.B.N. 75 008 659 498) | /(@) ______---_
Tel: (+61) 0500 83 82 81 | _________ \
Fax: (+61) 0500 83 82 82 | ___________ |
Http://www.rhyme.com.au | / \|
| --________--
PGP key available upon request, | /
and from pgp5.ai.mit.edu:11371 |/
At 18:36 21/10/00 +0700, Denis Perchine wrote:
here it is as requested by Bruce.
I tested it restoring my database with > 100000 BLOBS, and dumping it out.
But unfortunatly I can not restore it back due to problems in pg_dump.Please clarify - based on your last private email you stated that there was
not a problem with pg_dump, but a problem in the your BLOB patch:
Yeps. I have fixed all the crap. And it restores perfect from my archive
which I made some time ago with your pg_dump for 7.0.2. It was _10 if I am
not mistaken.Also it dumps out fine, but restore back from new archive stops right away.
And when I tried to do dump/restore on the empty database I was failed.
This is the same recent bug as from the hacker list?
----------------------------------------------------------------
Philip Warner | __---_____
Albatross Consulting Pty. Ltd. |----/ - \
(A.B.N. 75 008 659 498) | /(@) ______---_
Tel: (+61) 0500 83 82 81 | _________ \
Fax: (+61) 0500 83 82 82 | ___________ |
Http://www.rhyme.com.au | / \|
| --________--
PGP key available upon request, | /
and from pgp5.ai.mit.edu:11371 |/
Applied. Thanks. I know it is a pain to generate a new patch against
the release.
[ Charset koi8r unsupported, skipping... ]
[ Attachment, skipping... ]
--
Bruce Momjian | http://candle.pha.pa.us
pgman@candle.pha.pa.us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026
Bruce Momjian writes:
Applied. Thanks. I know it is a pain to generate a new patch against
the release.
Regression tests opr_sanity and sanity_check are now failing.
--
Peter Eisentraut peter_e@gmx.net http://yi.org/peter-e/
OK, Denis, can you run the regression tests with your patch and see what
is going on?
Bruce Momjian writes:
Applied. Thanks. I know it is a pain to generate a new patch against
the release.Regression tests opr_sanity and sanity_check are now failing.
--
Peter Eisentraut peter_e@gmx.net http://yi.org/peter-e/
--
Bruce Momjian | http://candle.pha.pa.us
pgman@candle.pha.pa.us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026Hi,
OK, Denis, can you run the regression tests with your patch and see what
is going on?Bruce Momjian writes:
Applied. Thanks. I know it is a pain to generate a new patch against
the release.Regression tests opr_sanity and sanity_check are now failing.
This was due to change in template1.
Here is regression.diff attached.
And also there's test.patch attached which will fix this.
--
Sincerely Yours,
Denis Perchine
----------------------------------
E-Mail: dyp@perchine.com
HomePage: http://www.perchine.com/dyp/
FidoNet: 2:5000/120.5
----------------------------------
Attachments:
regression.diffstext/english; name=regression.diffsDownload
*** ./expected/opr_sanity.out Mon Aug 21 11:48:57 2000
--- ./results/opr_sanity.out Sun Oct 22 13:16:40 2000
***************
*** 482,489 ****
(p2.pronargs = 1 AND p1.aggbasetype = 0)));
oid | aggname | oid | proname
-------+---------+-----+-------------
! 16984 | max | 768 | int4larger
! 16998 | min | 769 | int4smaller
(2 rows)
-- Cross-check finalfn (if present) against its entry in pg_proc.
--- 482,489 ----
(p2.pronargs = 1 AND p1.aggbasetype = 0)));
oid | aggname | oid | proname
-------+---------+-----+-------------
! 16996 | max | 768 | int4larger
! 17010 | min | 769 | int4smaller
(2 rows)
-- Cross-check finalfn (if present) against its entry in pg_proc.
======================================================================
*** ./expected/sanity_check.out Thu Jul 6 06:02:37 2000
--- ./results/sanity_check.out Sun Oct 22 13:16:55 2000
***************
*** 40,45 ****
--- 40,46 ----
pg_index | t
pg_inherits | t
pg_language | t
+ pg_largeobject | t
pg_listener | t
pg_opclass | t
pg_operator | t
***************
*** 54,58 ****
shighway | t
tenk1 | t
tenk2 | t
! (44 rows)
--- 55,59 ----
shighway | t
tenk1 | t
tenk2 | t
! (45 rows)
======================================================================
test.patchtext/english; name=test.patchDownload
Index: opr_sanity.out
===================================================================
RCS file: /home/projects/pgsql/cvsroot/pgsql/src/test/regress/expected/opr_sanity.out,v
retrieving revision 1.20
diff -u -r1.20 opr_sanity.out
--- opr_sanity.out 2000/08/21 04:48:57 1.20
+++ opr_sanity.out 2000/10/22 06:19:58
@@ -482,8 +482,8 @@
(p2.pronargs = 1 AND p1.aggbasetype = 0)));
oid | aggname | oid | proname
-------+---------+-----+-------------
- 16984 | max | 768 | int4larger
- 16998 | min | 769 | int4smaller
+ 16996 | max | 768 | int4larger
+ 17010 | min | 769 | int4smaller
(2 rows)
-- Cross-check finalfn (if present) against its entry in pg_proc.
Index: sanity_check.out
===================================================================
RCS file: /home/projects/pgsql/cvsroot/pgsql/src/test/regress/expected/sanity_check.out,v
retrieving revision 1.12
diff -u -r1.12 sanity_check.out
--- sanity_check.out 2000/07/05 23:02:37 1.12
+++ sanity_check.out 2000/10/22 06:19:58
@@ -40,6 +40,7 @@
pg_index | t
pg_inherits | t
pg_language | t
+ pg_largeobject | t
pg_listener | t
pg_opclass | t
pg_operator | t
@@ -54,5 +55,5 @@
shighway | t
tenk1 | t
tenk2 | t
-(44 rows)
+(45 rows)