Patch to support transactions with BLOBs for current CVS

Started by Denis Perchineover 25 years ago9 messageshackers
Jump to latest
#1Denis Perchine
dyp@perchine.com

Hello,

here it is as requested by Bruce.
I tested it restoring my database with > 100000 BLOBS, and dumping it out.
But unfortunatly I can not restore it back due to problems in pg_dump.

--
Sincerely Yours,
Denis Perchine

----------------------------------
E-Mail: dyp@perchine.com
HomePage: http://www.perchine.com/dyp/
FidoNet: 2:5000/120.5
----------------------------------

Attachments:

pgsql.lo.211000.patch.gzapplication/x-gzip; name=pgsql.lo.211000.patch.gzDownload
#2Denis Perchine
dyp@perchine.com
In reply to: Denis Perchine (#1)
Re: Patch to support transactions with BLOBs for current CVS

here it is as requested by Bruce.
I tested it restoring my database with > 100000 BLOBS, and dumping it out.
But unfortunatly I can not restore it back due to problems in pg_dump.

Please clarify - based on your last private email you stated that there was

not a problem with pg_dump, but a problem in the your BLOB patch:

Yeps. I have fixed all the crap. And it restores perfect from my archive
which I made some time ago with your pg_dump for 7.0.2. It was _10 if I am
not mistaken.

Also it dumps out fine, but restore back from new archive stops right away.
And when I tried to do dump/restore on the empty database I was failed.

From: Denis Perchine <dyp@perchine.com>
Date: Fri, 20 Oct 2000 12:15:18 +0700

Sorry... I had a look inside server log... Looks like my bug...

Are you now saying there is a new problem with pg_dump?

----------------------------------------------------------------
Philip Warner | __---_____
Albatross Consulting Pty. Ltd. |----/ - \
(A.B.N. 75 008 659 498) | /(@) ______---_
Tel: (+61) 0500 83 82 81 | _________ \
Fax: (+61) 0500 83 82 82 | ___________ |
Http://www.rhyme.com.au | / \|

| --________--

PGP key available upon request, | /
and from pgp5.ai.mit.edu:11371 |/

--
Sincerely Yours,
Denis Perchine

----------------------------------
E-Mail: dyp@perchine.com
HomePage: http://www.perchine.com/dyp/
FidoNet: 2:5000/120.5
----------------------------------

#3Denis Perchine
dyp@perchine.com
In reply to: Denis Perchine (#2)
Re: Patch to support transactions with BLOBs for current CVS

Yeps. I have fixed all the crap. And it restores perfect from my archive
which I made some time ago with your pg_dump for 7.0.2. It was _10 if I am
not mistaken.

Also it dumps out fine, but restore back from new archive stops right
away. And when I tried to do dump/restore on the empty database I was
failed.

This is the same recent bug as from the hacker list?

Yeps. I just made a comment that I was unable to make a complete circle in my
tests. :-)))

--
Sincerely Yours,
Denis Perchine

----------------------------------
E-Mail: dyp@perchine.com
HomePage: http://www.perchine.com/dyp/
FidoNet: 2:5000/120.5
----------------------------------

#4Philip Warner
pjw@rhyme.com.au
In reply to: Denis Perchine (#1)
Re: Patch to support transactions with BLOBs for current CVS

At 18:19 21/10/00 +0700, Denis Perchine wrote:

Hello,

here it is as requested by Bruce.
I tested it restoring my database with > 100000 BLOBS, and dumping it out.
But unfortunatly I can not restore it back due to problems in pg_dump.

Please clarify - based on your last private email you stated that there was
not a problem with pg_dump, but a problem in the your BLOB patch:

From: Denis Perchine <dyp@perchine.com>
Date: Fri, 20 Oct 2000 12:15:18 +0700

Sorry... I had a look inside server log... Looks like my bug...

Are you now saying there is a new problem with pg_dump?

----------------------------------------------------------------
Philip Warner | __---_____
Albatross Consulting Pty. Ltd. |----/ - \
(A.B.N. 75 008 659 498) | /(@) ______---_
Tel: (+61) 0500 83 82 81 | _________ \
Fax: (+61) 0500 83 82 82 | ___________ |
Http://www.rhyme.com.au | / \|
| --________--
PGP key available upon request, | /
and from pgp5.ai.mit.edu:11371 |/

#5Philip Warner
pjw@rhyme.com.au
In reply to: Denis Perchine (#2)
Re: Patch to support transactions with BLOBs for current CVS

At 18:36 21/10/00 +0700, Denis Perchine wrote:

here it is as requested by Bruce.
I tested it restoring my database with > 100000 BLOBS, and dumping it out.
But unfortunatly I can not restore it back due to problems in pg_dump.

Please clarify - based on your last private email you stated that there was

not a problem with pg_dump, but a problem in the your BLOB patch:

Yeps. I have fixed all the crap. And it restores perfect from my archive
which I made some time ago with your pg_dump for 7.0.2. It was _10 if I am
not mistaken.

Also it dumps out fine, but restore back from new archive stops right away.
And when I tried to do dump/restore on the empty database I was failed.

This is the same recent bug as from the hacker list?

----------------------------------------------------------------
Philip Warner | __---_____
Albatross Consulting Pty. Ltd. |----/ - \
(A.B.N. 75 008 659 498) | /(@) ______---_
Tel: (+61) 0500 83 82 81 | _________ \
Fax: (+61) 0500 83 82 82 | ___________ |
Http://www.rhyme.com.au | / \|
| --________--
PGP key available upon request, | /
and from pgp5.ai.mit.edu:11371 |/

#6Bruce Momjian
bruce@momjian.us
In reply to: Denis Perchine (#1)
Re: Patch to support transactions with BLOBs for current CVS

Applied. Thanks. I know it is a pain to generate a new patch against
the release.

[ Charset koi8r unsupported, skipping... ]

[ Attachment, skipping... ]

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026
#7Peter Eisentraut
peter_e@gmx.net
In reply to: Bruce Momjian (#6)
Re: [PATCHES] Patch to support transactions with BLOBs for current CVS

Bruce Momjian writes:

Applied. Thanks. I know it is a pain to generate a new patch against
the release.

Regression tests opr_sanity and sanity_check are now failing.

--
Peter Eisentraut peter_e@gmx.net http://yi.org/peter-e/

#8Bruce Momjian
bruce@momjian.us
In reply to: Peter Eisentraut (#7)
Re: Re: [PATCHES] Patch to support transactions with BLOBs for current CVS

OK, Denis, can you run the regression tests with your patch and see what
is going on?

Bruce Momjian writes:

Applied. Thanks. I know it is a pain to generate a new patch against
the release.

Regression tests opr_sanity and sanity_check are now failing.

--
Peter Eisentraut peter_e@gmx.net http://yi.org/peter-e/

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026
#9Denis Perchine
dyp@perchine.com
In reply to: Bruce Momjian (#8)
Re: Re: [PATCHES] Patch to support transactions with BLOBs for current CVS

Hi,

OK, Denis, can you run the regression tests with your patch and see what
is going on?

Bruce Momjian writes:

Applied. Thanks. I know it is a pain to generate a new patch against
the release.

Regression tests opr_sanity and sanity_check are now failing.

This was due to change in template1.
Here is regression.diff attached.

And also there's test.patch attached which will fix this.

--
Sincerely Yours,
Denis Perchine

----------------------------------
E-Mail: dyp@perchine.com
HomePage: http://www.perchine.com/dyp/
FidoNet: 2:5000/120.5
----------------------------------

Attachments:

regression.diffstext/english; name=regression.diffsDownload+7-6
test.patchtext/english; name=test.patchDownload+4-3