minor tweak to catalogs.sgml pg_class.reltablespace

Started by Alvaro Herreraover 2 years ago3 messageshackers
Beta feature

Hackorum builds and tests every patch posted to the lists, not only commitfest submissions. This is Hackorum's own CI rather than the PostgreSQL project's, and it is still under testing - please report anything that looks wrong.

won't retrysuccessCI history

You can run a PostgreSQL built from this patch straight from Docker, with no checkout and no build:

docker run --rm -p 5432:5432 ghcr.io/hackorum-dev/postgres-patch:t49337
psql -h localhost -U postgres

Built from patchset v1 (message #1), July 27, 2026 at 11:05 PM.

Every patchset is also pushed to a branch of our PostgreSQL fork, so you can check out the same tree CI built. Without a PostgreSQL checkout:

git clone --branch t49337_1 https://github.com/hackorum-dev/postgres.git

In a checkout you already have, add the fork once:

git remote add hackorum https://github.com/hackorum-dev/postgres.git

then, for this patchset and every later one:

git fetch hackorum t49337_1 && git checkout t49337_1

Patchset v1 (message #1) is on t49337_1

Jump to latest
#1Alvaro Herrera
alvherre@2ndquadrant.com

While reviewing the patch for SET ACCESS METHOD[1]/messages/by-id/202403191013.w2kr7wqlamqz@alvherre.pgsql I noticed that
pg_class.relam is not documented fully for partitioned tables, so I
proposed the attached. Also, I remove a comment that merely repeats
what was already said a few lines above.

This is intended for backpatch to 12.

[1]: /messages/by-id/202403191013.w2kr7wqlamqz@alvherre.pgsql

--
Álvaro Herrera Breisgau, Deutschland — https://www.EnterpriseDB.com/

Attachments:

t49337_1
0001-Review-for-wording-on-tablespaces-on-partitioned-tab.patchtext/x-diff; charset=utf-8Download+5-8
#2Tom Lane
tgl@sss.pgh.pa.us
In reply to: Alvaro Herrera (#1)
Re: minor tweak to catalogs.sgml pg_class.reltablespace

Alvaro Herrera <alvherre@alvh.no-ip.org> writes:

While reviewing the patch for SET ACCESS METHOD[1] I noticed that
pg_class.relam is not documented fully for partitioned tables, so I
proposed the attached.

The bit about "(Not meaningful if the relation has no on-disk file.)"
is not correct, and now it's adjacent to text that contradicts it.
Maybe more like

The tablespace in which this relation is stored.
If zero, the database's default tablespace is implied.
Not meaningful if the relation has no on-disk file,
except for partitioned tables, where this is the tablespace
in which partitions will be created when one is not
specified in the creation command.

regards, tom lane

#3Alvaro Herrera
alvherre@2ndquadrant.com
In reply to: Tom Lane (#2)
Re: minor tweak to catalogs.sgml pg_class.reltablespace

On 2024-Mar-19, Tom Lane wrote:

The bit about "(Not meaningful if the relation has no on-disk file.)"
is not correct, and now it's adjacent to text that contradicts it.
Maybe more like

The tablespace in which this relation is stored.
If zero, the database's default tablespace is implied.
Not meaningful if the relation has no on-disk file,
except for partitioned tables, where this is the tablespace
in which partitions will be created when one is not
specified in the creation command.

I like that wording, thanks, pushed like that.

--
Álvaro Herrera PostgreSQL Developer — https://www.EnterpriseDB.com/
"Right now the sectors on the hard disk run clockwise, but I heard a rumor that
you can squeeze 0.2% more throughput by running them counterclockwise.
It's worth the effort. Recommended." (Gerry Pourwelle)