fix pg_upgrade comment

Started by Nathan Bossartalmost 2 years ago3 messageshackers
Jump to latest
#1Nathan Bossart
nathandbossart@gmail.com

I noticed that the "check" variable, which is used for "pg_upgrade
--check", is commented as follows:

bool check; /* true -> ask user for permission to make
* changes */

This comment was first added when pg_upgrade was introduced (commit
c2e9b2f288), but I imagine it predates even that. I've attached a patch to
fix this. Barring objections, I'll probably commit this soon.

--
nathan

Attachments:

v1-0001-pg_upgrade-fix-comment.patchtext/plain; charset=us-asciiDownload+1-3
#2Daniel Gustafsson
daniel@yesql.se
In reply to: Nathan Bossart (#1)
Re: fix pg_upgrade comment

On 18 Jun 2024, at 21:50, Nathan Bossart <nathandbossart@gmail.com> wrote:

I noticed that the "check" variable, which is used for "pg_upgrade
--check", is commented as follows:

bool check; /* true -> ask user for permission to make
* changes */

This comment was first added when pg_upgrade was introduced (commit
c2e9b2f288), but I imagine it predates even that. I've attached a patch to
fix this. Barring objections, I'll probably commit this soon.

Nice catch, +1 for committing.

--
Daniel Gustafsson

#3Nathan Bossart
nathandbossart@gmail.com
In reply to: Daniel Gustafsson (#2)
Re: fix pg_upgrade comment

On Tue, Jun 18, 2024 at 10:20:06PM +0200, Daniel Gustafsson wrote:

Nice catch, +1 for committing.

Committed.

--
nathan