Missing installation of Kerberos.pm and AdjustUpgrade.pm

Started by Michael Paquieralmost 2 years ago3 messageshackers
Jump to latest
#1Michael Paquier
michael@paquier.xyz

Hi all,
(cc-ing Tom as committer of 52585f8f072a)

As Ashutosh has mentioned here we are not installing AdjustUpgrade.pm:
/messages/by-id/CAExHW5sja9YqZhin+UOp4DuHJwmgZc86YGDkXeEEW+HVyCvRnA@mail.gmail.com

The same thing can be said for Kerberos.pm.

Could there be an argument for updating src/test/perl/meson.build and
src/test/perl/Makefile with install and uninstall rules for both pm
files?

I cannot say much in favor of Kerberos.pm, but AdjustUpgrade.pm could
be really useful IMO when running the main regression test suite in an
out-of-core module for upgrade scenarios. Not to mention that it
includes a set of filtering regexes that are rather generic.

Comments?
--
Michael

#2Michael Paquier
michael@paquier.xyz
In reply to: Michael Paquier (#1)
Re: Missing installation of Kerberos.pm and AdjustUpgrade.pm

On Tue, Jul 09, 2024 at 04:46:23PM +0900, Michael Paquier wrote:

I cannot say much in favor of Kerberos.pm, but AdjustUpgrade.pm could
be really useful IMO when running the main regression test suite in an
out-of-core module for upgrade scenarios. Not to mention that it
includes a set of filtering regexes that are rather generic.

While catching up with some other thing, I've been reminded that this
has not been addressed. Any objections if I were to apply the
attached to add install and uninstall rules for Kerberos.pm and
AdjustUpgrade.pm?

If people would prefer a backpatch, please let me know.
--
Michael

Attachments:

0001-Add-rules-for-Kerberos.pm-and-AdjustUpgrade.pm.patchtext/x-diff; charset=us-asciiDownload+6-1
#3Michael Paquier
michael@paquier.xyz
In reply to: Michael Paquier (#2)
Re: Missing installation of Kerberos.pm and AdjustUpgrade.pm

On Thu, Oct 24, 2024 at 02:51:05PM +0900, Michael Paquier wrote:

While catching up with some other thing, I've been reminded that this
has not been addressed. Any objections if I were to apply the
attached to add install and uninstall rules for Kerberos.pm and
AdjustUpgrade.pm?

If people would prefer a backpatch, please let me know.

Hearing nothing, applied this one on HEAD for now.
--
Michael