src/backend/optimizer/util/plancat.c -> Is this correct English

Started by Daniel Westermann (DWE)over 1 year ago4 messages
#1Daniel Westermann (DWE)
daniel.westermann@dbi-services.com

Hi,

just came across this:

src/backend/optimizer/util/plancat.c -> Is this correct English?
-> We need not lock the relation since it was already locked ...

I am not a native speaker, but this sounds strange.

Regards
Daniel?

#2Nathan Bossart
nathandbossart@gmail.com
In reply to: Daniel Westermann (DWE) (#1)
Re: src/backend/optimizer/util/plancat.c -> Is this correct English

On Wed, Sep 25, 2024 at 04:52:47PM +0000, Daniel Westermann (DWE) wrote:

just came across this:

src/backend/optimizer/util/plancat.c -> Is this correct English?
-> We need not lock the relation since it was already locked ...

I am not a native speaker, but this sounds strange.

I think it's fine. It could also be phrased like this:

We do not need to lock the relation since...

--
nathan

#3Daniel Westermann (DWE)
daniel.westermann@dbi-services.com
In reply to: Nathan Bossart (#2)
Re: src/backend/optimizer/util/plancat.c -> Is this correct English

I think it's fine. It could also be phrased like this:

We do not need to lock the relation since...

That's what I would have expected. But, as said, maybe this only sounds strange to me.

Regards
Daniel

#4Tom Lane
tgl@sss.pgh.pa.us
In reply to: Daniel Westermann (DWE) (#3)
Re: src/backend/optimizer/util/plancat.c -> Is this correct English

"Daniel Westermann (DWE)" <daniel.westermann@dbi-services.com> writes:

That's what I would have expected. But, as said, maybe this only sounds strange to me.

"Need not" is perfectly good English, although perhaps it has a
faintly archaic whiff to it.

regards, tom lane