Typo spotted in GetFileBackupMethod comment(?)

Started by Haoran Zhangalmost 2 years ago1 messageshackers
Beta feature

Hackorum builds and tests every patch posted to the lists, not only commitfest submissions. This is Hackorum's own CI rather than the PostgreSQL project's, and it is still under testing - please report anything that looks wrong.

appliessuccessCI history

You can run a PostgreSQL built from this patch straight from Docker, with no checkout and no build:

docker run --rm -p 5432:5432 ghcr.io/hackorum-dev/postgres-patch:t50444
psql -h localhost -U postgres

Built from patchset v1 (message #1), August 17, 2026 at 09:40 AM.

Jump to latest
#1Haoran Zhang
andrewzhr9911@gmail.com

Hey Robert,

I'm investigating how PostgresQL 17 does incremental backup and find this
comment of GetFileBackupMethod a bit off. relative_block_numbers being an
array of at *most* RELSEG_SIZE makes more sense to me. So I made this patch
to address it.

Note that this is the first time I made a patch for the community. So
kindly bear with me if I did it wrong somehow.

Best,
Haoran

Attachments:

v01-fix_GetFileBackupMethod_comment.patchapplication/octet-stream; name=v01-fix_GetFileBackupMethod_comment.patchDownload+1-1