tab_complete for copy(merge

Started by jian heabout 1 year ago4 messages
#1jian he
jian.universality@gmail.com

hi.

in v17, we support COPY(MERGE RETURNING)
we can add tab_complete for it.

    /* Complete COPY ( with legal query commands */
    else if (Matches("COPY|\\copy", "("))
-               COMPLETE_WITH("SELECT", "TABLE", "VALUES", "INSERT
INTO", "UPDATE", "DELETE FROM", "WITH");
+               COMPLETE_WITH("SELECT", "TABLE", "VALUES", "INSERT
INTO", "UPDATE", "DELETE FROM", "WITH", "MERGE INTO");
#2Kirill Reshke
reshkekirill@gmail.com
In reply to: jian he (#1)
Re: tab_complete for copy(merge

Hi!

On Tue, 19 Nov 2024, 14:08 jian he, <jian.universality@gmail.com> wrote:

hi.

in v17, we support COPY(MERGE RETURNING)
we can add tab_complete for it.

Sounds sane

/* Complete COPY ( with legal query commands */
else if (Matches("COPY|\\copy", "("))
-               COMPLETE_WITH("SELECT", "TABLE", "VALUES", "INSERT
INTO", "UPDATE", "DELETE FROM", "WITH");
+               COMPLETE_WITH("SELECT", "TABLE", "VALUES", "INSERT
INTO", "UPDATE", "DELETE FROM", "WITH", "MERGE INTO");

MERGE INTO?

#3jian he
jian.universality@gmail.com
In reply to: Kirill Reshke (#2)
Re: tab_complete for copy(merge

On Tue, Nov 19, 2024 at 5:20 PM Kirill Reshke <reshkekirill@gmail.com> wrote:

Hi!

On Tue, 19 Nov 2024, 14:08 jian he, <jian.universality@gmail.com> wrote:

hi.

in v17, we support COPY(MERGE RETURNING)
we can add tab_complete for it.

Sounds sane

/* Complete COPY ( with legal query commands */
else if (Matches("COPY|\\copy", "("))
-               COMPLETE_WITH("SELECT", "TABLE", "VALUES", "INSERT
INTO", "UPDATE", "DELETE FROM", "WITH");
+               COMPLETE_WITH("SELECT", "TABLE", "VALUES", "INSERT
INTO", "UPDATE", "DELETE FROM", "WITH", "MERGE INTO");

MERGE INTO?

per Synopsis
https://www.postgresql.org/docs/current/sql-merge.html
it should be "MERGE INTO".

#4Peter Eisentraut
peter@eisentraut.org
In reply to: jian he (#3)
Re: tab_complete for copy(merge

On 19.11.24 14:23, jian he wrote:

On Tue, Nov 19, 2024 at 5:20 PM Kirill Reshke <reshkekirill@gmail.com> wrote:

On Tue, 19 Nov 2024, 14:08 jian he, <jian.universality@gmail.com> wrote:

in v17, we support COPY(MERGE RETURNING)
we can add tab_complete for it.

Sounds sane

/* Complete COPY ( with legal query commands */
else if (Matches("COPY|\\copy", "("))
-               COMPLETE_WITH("SELECT", "TABLE", "VALUES", "INSERT
INTO", "UPDATE", "DELETE FROM", "WITH");
+               COMPLETE_WITH("SELECT", "TABLE", "VALUES", "INSERT
INTO", "UPDATE", "DELETE FROM", "WITH", "MERGE INTO");

MERGE INTO?

per Synopsis
https://www.postgresql.org/docs/current/sql-merge.html
it should be "MERGE INTO".

Yes, we also complete "MERGE INTO" in other contexts.

Committed like that.