Refactor WinGetFuncArgInFrame
Hackorum builds and tests every patch posted to the lists, not only commitfest submissions. This is Hackorum's own CI rather than the PostgreSQL project's, and it is still under testing - please report anything that looks wrong.
You can run a PostgreSQL built from this patch straight from Docker, with no checkout and no build:
docker run --rm -p 5432:5432 ghcr.io/hackorum-dev/postgres-patch:t50853psql -h localhost -U postgresBuilt from patchset v1 (message #1), July 27, 2026 at 10:35 AM.
Every patchset is also pushed to a branch of our PostgreSQL fork, so you can check out the same tree CI built. Without a PostgreSQL checkout:
git clone --branch t50853_1 https://github.com/hackorum-dev/postgres.gitIn a checkout you already have, add the fork once:
git remote add hackorum https://github.com/hackorum-dev/postgres.gitthen, for this patchset and every later one:
git fetch hackorum t50853_1 && git checkout t50853_1Patchset v1 (message #1) is on t50853_1
While working on this:
/messages/by-id/20230625.210509.1276733411677577841.t-ishii@sranhm.sra.co.jp
I noticed that WinGetFuncArgInFrame() in nodeWindowAgg.c is hard to
read/understand. I think part of the reason is, it is long and has
large switch case and uses goto. I propose to refactor the function to
mitigate the issue. With attached patch, the large switch case is
moved to a new static function WinGetSlotInFrame().
Best reagards,
--
Tatsuo Ishii
SRA OSS K.K.
English: http://www.sraoss.co.jp/index_en/
Japanese:http://www.sraoss.co.jp