Remove a unnecessary argument from execute_extension_script()

Started by Yugo Nagataover 1 year ago4 messageshackers
Jump to latest
#1Yugo Nagata
nagata@sraoss.co.jp

Hi,

The attached patch is to remove a unnecessary argument "schemaOid"
from the static function execute_extension_script(). It might have
been intended to be used some way initially, but actually this is
not used since schemaName is sufficient.

Regards,
Yugo Nagata

--
Yugo Nagata <nagata@sraoss.co.jp>

Attachments:

extension_remove_unnecessary_arg.patchtext/x-diff; name=extension_remove_unnecessary_arg.patchDownload+3-3
#2Fabrízio de Royes Mello
fabriziomello@gmail.com
In reply to: Yugo Nagata (#1)
Re: Remove a unnecessary argument from execute_extension_script()

On Thu, Feb 13, 2025 at 1:02 PM Yugo Nagata <nagata@sraoss.co.jp> wrote:

Hi,

The attached patch is to remove a unnecessary argument "schemaOid"
from the static function execute_extension_script(). It might have
been intended to be used some way initially, but actually this is
not used since schemaName is sufficient.

LGTM.

--
Fabrízio de Royes Mello

#3Nathan Bossart
nathandbossart@gmail.com
In reply to: Fabrízio de Royes Mello (#2)
Re: Remove a unnecessary argument from execute_extension_script()

On Thu, Feb 13, 2025 at 03:18:51PM -0300, Fabrízio de Royes Mello wrote:

On Thu, Feb 13, 2025 at 1:02 PM Yugo Nagata <nagata@sraoss.co.jp> wrote:

The attached patch is to remove a unnecessary argument "schemaOid"
from the static function execute_extension_script(). It might have
been intended to be used some way initially, but actually this is
not used since schemaName is sufficient.

LGTM.

Interesting. This parameter seems to have appeared between v30 [0]/messages/by-id/m24o8nhd69.fsf@2ndQuadrant.fr and v31
[1]: /messages/by-id/4171.1297135840@sss.pgh.pa.us
from a quick skim, I don't see any discussion about it. I'll plan on
committing this shortly.

[0]: /messages/by-id/m24o8nhd69.fsf@2ndQuadrant.fr
[1]: /messages/by-id/4171.1297135840@sss.pgh.pa.us

--
nathan

#4Nathan Bossart
nathandbossart@gmail.com
In reply to: Nathan Bossart (#3)
Re: Remove a unnecessary argument from execute_extension_script()

Committed.

--
nathan