Unify a recently-added inconsisnt message

Started by Kyotaro Horiguchiabout 1 year ago2 messageshackers
Jump to latest
#1Kyotaro Horiguchi
horikyota.ntt@gmail.com

Subject: Unify a recent-added inconsisnt message

Hello.

I noticed that the recent commit cd3c45125d2 introduced the following
three inconsistent messages at the same time:

pg_dump.c:
+ printf(_(" --no-policies do not dump row security policies\n"));

pg_dumpall.c:
+ printf(_(" --no-policies do not dump row security policies\n"));

pg_restore.c:
+ printf(_(" --no-policies do not restore row level security policies\n"));

The existing user-facing messages commonly use "row security".
Therefore, I believe the newly introduced message should follow the
same wording for consistency.

Please find the attached patch that updates the inconsistent message.

--
Kyotaro Horiguchi
NTT Open Source Software Center

Attachments:

0001-Unify-wording-of-user-facing-row-security.patchtext/x-patch; charset=us-asciiDownload+1-2
#2Tom Lane
tgl@sss.pgh.pa.us
In reply to: Kyotaro Horiguchi (#1)
Re: Unify a recently-added inconsisnt message

Kyotaro Horiguchi <horikyota.ntt@gmail.com> writes:

I noticed that the recent commit cd3c45125d2 introduced the following
three inconsistent messages at the same time:
pg_dump.c:
+       printf(_("  --no-policies                do not dump row security policies\n"));
pg_dumpall.c:
+       printf(_("  --no-policies                do not dump row security policies\n"));
pg_restore.c:
+       printf(_("  --no-policies                do not restore row level security policies\n"));

Ooops :-(. I should have caught that during review.

Please find the attached patch that updates the inconsistent message.

Pushed, thanks for noticing it.

regards, tom lane