Question about comments on simple_heap_update

Started by Yugo Nagataover 1 year ago1 messageshackers
Jump to latest
#1Yugo Nagata
nagata@sraoss.co.jp

Hi,

While working on [1]/messages/by-id/20250331200057.00a62760966a821d484ea904@sraoss.co.jp, I found the internal error "tuple concurrently updated"
is raised by simple_heap_update and other similar functions, and the comments
on them says "Any failure is reported via ereport()". However, I could not understand
the intension of this comments because I suppose the unexpected errors are usual
reported via elog() not ereport and in fact elog() is used in these functions.

I wonder this statement should be fixed as the attached patch or could be removed for
less confusion. Maybe, I am just missing something, though....

[1]: /messages/by-id/20250331200057.00a62760966a821d484ea904@sraoss.co.jp

--
Yugo Nagata <nagata@sraoss.co.jp>

Attachments:

fix_comments_on_siple_heap_update.patchtext/x-diff; name=fix_comments_on_siple_heap_update.patchDownload+4-4