[PATCH] Fix <literal> tags in func.sgml

Started by Noboru Saito8 months ago6 messages

noborusai@gmail.com

8 months ago

1 attachment(s)

Hi,

Previously, both "AT TIME ZONE" and "AT LOCAL" were wrapped in a
single <literal> tag, which was incorrect.
This patch separates them into two distinct <literal> tags for better
semantic correctness.

Please review and apply if appropriate.
Noboru Saito

Attachments:

fix-literal-tag.difftext/x-patch; charset=US-ASCII; name=fix-literal-tag.diffDownload

diff --git a/doc/src/sgml/func.sgml b/doc/src/sgml/func.sgml
index 27ec46105f4..b405525a465 100644
--- a/doc/src/sgml/func.sgml
+++ b/doc/src/sgml/func.sgml
@@ -10905,7 +10905,7 @@ SELECT date_bin('15 minutes', TIMESTAMP '2020-02-11 15:44:17', TIMESTAMP '2001-0
   </sect2>
 
   <sect2 id="functions-datetime-zoneconvert">
-   <title><literal>AT TIME ZONE and AT LOCAL</literal></title>
+   <title><literal>AT TIME ZONE</literal> and <literal>AT LOCAL</literal></title>
 
    <indexterm>
     <primary>time zone</primary>

Daniel Gustafsson

daniel@yesql.se

8 months ago

In reply to: Noboru Saito (#1)

Re: [PATCH] Fix <literal> tags in func.sgml

On 8 May 2025, at 08:36, Noboru Saito <noborusai@gmail.com> wrote:

Hi,

Previously, both "AT TIME ZONE" and "AT LOCAL" were wrapped in a
single <literal> tag, which was incorrect.
This patch separates them into two distinct <literal> tags for better
semantic correctness.

Thanks for the patch, it looks correct to me so I will apply it in a bit.

--
Daniel Gustafsson

Tatsuo Ishii

ishii@postgresql.org

8 months ago

In reply to: Noboru Saito (#1)

Re: [PATCH] Fix <literal> tags in func.sgml

Previously, both "AT TIME ZONE" and "AT LOCAL" were wrapped in a
single <literal> tag, which was incorrect.

Agreed.

This patch separates them into two distinct <literal> tags for better
semantic correctness.

Please review and apply if appropriate.
Noboru Saito

Looks good to me.

Best regards,
--
Tatsuo Ishii
SRA OSS K.K.
English: http://www.sraoss.co.jp/index_en/
Japanese:http://www.sraoss.co.jp

Tatsuo Ishii

ishii@postgresql.org

8 months ago

In reply to: Daniel Gustafsson (#2)

Re: [PATCH] Fix <literal> tags in func.sgml

On 8 May 2025, at 08:36, Noboru Saito <noborusai@gmail.com> wrote:

Hi,

Previously, both "AT TIME ZONE" and "AT LOCAL" were wrapped in a
single <literal> tag, which was incorrect.
This patch separates them into two distinct <literal> tags for better
semantic correctness.

Thanks for the patch, it looks correct to me so I will apply it in a bit.

Sorry I havent' noticed your email when I posted. Please go ahead.

Best regards,
--
Tatsuo Ishii
SRA OSS K.K.
English: http://www.sraoss.co.jp/index_en/
Japanese:http://www.sraoss.co.jp

Michael Paquier

michael@paquier.xyz

8 months ago

In reply to: Noboru Saito (#1)

Re: [PATCH] Fix <literal> tags in func.sgml

On Thu, May 08, 2025 at 03:36:53PM +0900, Noboru Saito wrote:

Previously, both "AT TIME ZONE" and "AT LOCAL" were wrapped in a
single <literal> tag, which was incorrect.
This patch separates them into two distinct <literal> tags for better
semantic correctness.

Indeed, good catch. It looks like I've fat-fingered the tag in
97957fdbaa42. The suggested patch looks OK here.
--
Michael

Noboru Saito

noborusai@gmail.com

8 months ago

In reply to: Daniel Gustafsson (#2)

Re: [PATCH] Fix <literal> tags in func.sgml

Thanks to all the hackers for your quick response.

2025年5月8日(木) 15:44 Daniel Gustafsson <daniel@yesql.se>:

Show quoted text

On 8 May 2025, at 08:36, Noboru Saito <noborusai@gmail.com> wrote:

Hi,

Previously, both "AT TIME ZONE" and "AT LOCAL" were wrapped in a
single <literal> tag, which was incorrect.
This patch separates them into two distinct <literal> tags for better
semantic correctness.

Thanks for the patch, it looks correct to me so I will apply it in a bit.

--
Daniel Gustafsson