[PATCH] Correct src/backend/lib/README

Started by Aleksander Alekseev10 months ago4 messageshackers
Jump to latest
#1Aleksander Alekseev
aleksander@timescale.com

Hi,

I noticed that src/backend/lib/README references binaryheap.c and
stringinfo.c. These files were moved to src/backend/lib. Thus
mentioning them here doesn't look right.

Also README tries to explain the difference between binary heap and
pairing heap. Not sure whether we should keep this text and/or move
the pairing heap implementation closer to binary heap.

--
Best regards,
Aleksander Alekseev

Attachments:

v1-0001-Correct-src-backend-lib-README.patchapplication/octet-stream; name=v1-0001-Correct-src-backend-lib-README.patchDownload+0-5
#2Aleksander Alekseev
aleksander@timescale.com
In reply to: Aleksander Alekseev (#1)
Re: [PATCH] Correct src/backend/lib/README

Hi,

These files were moved to src/backend/lib

That is - src/common. Sorry for the confusion.

--
Best regards,
Aleksander Alekseev

#3Michael Paquier
michael@paquier.xyz
In reply to: Aleksander Alekseev (#2)
Re: [PATCH] Correct src/backend/lib/README

On Wed, Jun 25, 2025 at 08:58:05PM +0300, Aleksander Alekseev wrote:

These files were moved to src/backend/lib

That is - src/common. Sorry for the confusion.

No problem, good catches. Agreed to remove these references in the
README of backend/lib/. Will fix if there are no objections.
--
Michael

#4Michael Paquier
michael@paquier.xyz
In reply to: Michael Paquier (#3)
Re: [PATCH] Correct src/backend/lib/README

On Thu, Jun 26, 2025 at 07:37:46AM +0900, Michael Paquier wrote:

No problem, good catches. Agreed to remove these references in the
README of backend/lib/. Will fix if there are no objections.

Applied that.
--
Michael