[PATCH] plperl: use xsubpp -output unconditionally

Started by Dagfinn Ilmari Mannsåkerabout 1 year ago2 messageshackers
Beta feature

Hackorum builds and tests every patch posted to the lists, not only commitfest submissions. This is Hackorum's own CI rather than the PostgreSQL project's, and it is still under testing - please report anything that looks wrong.

appliessuccessCI history

You can run a PostgreSQL built from this patch straight from Docker, with no checkout and no build:

docker run --rm -p 5432:5432 ghcr.io/hackorum-dev/postgres-patch:t51848
psql -h localhost -U postgres

Built from patchset v1 (message #1), September 21, 2026 at 03:19 AM.

Every patchset is also pushed to a branch of our PostgreSQL fork, so you can check out the same tree CI built. Without a PostgreSQL checkout:

git clone --branch t51848_1 https://github.com/hackorum-dev/postgres.git

In a checkout you already have, add the fork once:

git remote add hackorum https://github.com/hackorum-dev/postgres.git

then, for this patchset and every later one:

git fetch hackorum t51848_1 && git checkout t51848_1

Patchset v1 (message #1) is on t51848_1

Jump to latest

Hi hackers,

I noticed that the PL/Perl makefile makes the use of the -output option
conditional on coverage+vpath, because that option is not supported
until Perl 5.9.3. But these days we require Perl 5.14, so we can remove
that conditional (which also matches what Meson does). Please see the
attached.

- ilmari

Attachments:

t51848_1
0001-Make-use-of-xsubpp-output-unconditional.patchtext/x-diffDownload+0-7
#2Daniel Gustafsson
daniel@yesql.se
In reply to: Dagfinn Ilmari Mannsåker (#1)
Re: [PATCH] plperl: use xsubpp -output unconditionally

On 2 Jul 2025, at 16:29, Dagfinn Ilmari Mannsåker <ilmari@ilmari.org> wrote:

I noticed that the PL/Perl makefile makes the use of the -output option
conditional on coverage+vpath, because that option is not supported
until Perl 5.9.3. But these days we require Perl 5.14, so we can remove
that conditional (which also matches what Meson does). Please see the
attached.

Nice catch. On that note, shouldn't we also be updating ppport.h with a new
--compat-version run?

--
Daniel Gustafsson