duplicate line in ExecEvalJsonCoercionFinish

jian he <jian.universality@gmail.com> 于2025年7月17日周四 07:39写道：

hi.

ExecEvalJsonCoercionFinish duplicate line:
jsestate->escontext.error_occurred = false;
jsestate->escontext.error_occurred = false;

https://git.postgresql.org/cgit/postgresql.git/tree/src/backend/executor/execExprInterp.c#n5230

Good catch. It was introduced by this commit 231b7d670b21.
Add Amit to the cc list.

--
Thanks,
Tender Wang

On Thu, Jul 17, 2025 at 9:52 AM Tender Wang <tndrwang@gmail.com> wrote:

jian he <jian.universality@gmail.com> 于2025年7月17日周四 07:39写道：

ExecEvalJsonCoercionFinish duplicate line:
jsestate->escontext.error_occurred = false;
jsestate->escontext.error_occurred = false;

Good catch. It was introduced by this commit 231b7d670b21.
Add Amit to the cc list.

Nice catch! The two duplicate statements were introduced in separate
commits; looks like a copy-paste oversight in the later one.

Thanks
Richard

On Thu, Jul 17, 2025 at 10:01 AM Richard Guo <guofenglinux@gmail.com> wrote:

On Thu, Jul 17, 2025 at 9:52 AM Tender Wang <tndrwang@gmail.com> wrote:

jian he <jian.universality@gmail.com> 于2025年7月17日周四 07:39写道：

ExecEvalJsonCoercionFinish duplicate line:
jsestate->escontext.error_occurred = false;
jsestate->escontext.error_occurred = false;

Good catch. It was introduced by this commit 231b7d670b21.
Add Amit to the cc list.

Nice catch! The two duplicate statements were introduced in separate
commits; looks like a copy-paste oversight in the later one.

Oops, you're right -- I must have copy-pasted without noticing the
duplicate. Thanks Jian for catching that. Will fix.

--
Thanks, Amit Langote

On Thu, Jul 17, 2025 at 12:03 PM Amit Langote <amitlangote09@gmail.com> wrote:

On Thu, Jul 17, 2025 at 10:01 AM Richard Guo <guofenglinux@gmail.com> wrote:

On Thu, Jul 17, 2025 at 9:52 AM Tender Wang <tndrwang@gmail.com> wrote:

jian he <jian.universality@gmail.com> 于2025年7月17日周四 07:39写道：

ExecEvalJsonCoercionFinish duplicate line:
jsestate->escontext.error_occurred = false;
jsestate->escontext.error_occurred = false;

Good catch. It was introduced by this commit 231b7d670b21.
Add Amit to the cc list.

Nice catch! The two duplicate statements were introduced in separate
commits; looks like a copy-paste oversight in the later one.

Oops, you're right -- I must have copy-pasted without noticing the
duplicate. Thanks Jian for catching that. Will fix.

Done. Thanks all.

--
Thanks, Amit Langote