Trivial patch to fix a typo

Started by Chao Li9 months ago5 messageshackers
Jump to latest
#1Chao Li
li.evan.chao@gmail.com

Hi Committers,

I happened to catch this typo while reading the regression test code, so
submitting a fix.

As the typo is in the code comment, no test needs to run.

Best regards,
Chao Li (Evan)
------------------------------
HighGo Software Inc.
https://www.highgo.com/

Attachments:

v1-0001-Fixed-a-typo-in-src-test-regress-sql-foreign_key..patchapplication/octet-stream; name=v1-0001-Fixed-a-typo-in-src-test-regress-sql-foreign_key..patchDownload+1-1
#2Michael Paquier
michael@paquier.xyz
In reply to: Chao Li (#1)
Re: Trivial patch to fix a typo

On Fri, Aug 01, 2025 at 02:56:33PM +0800, Chao Li wrote:

I happened to catch this typo while reading the regression test code, so
submitting a fix.

As the typo is in the code comment, no test needs to run.

Incorrect. The comment is included in the generated output, impacting
also foreign_key.out. If you run a simple `make check` you would see
that the tests fail.
--
Michael

#3Chao Li
li.evan.chao@gmail.com
In reply to: Michael Paquier (#2)
Re: Trivial patch to fix a typo

Ah ... Good to learn. Attached v2 updated the out file as well, now the
test passed:

$ make check
...
# All 229 tests passed.

Thanks a lot.
Chao Li (Evan)
------------------------------
HighGo Software Inc.
https://www.highgo.com/

Michael Paquier <michael@paquier.xyz> 于2025年8月1日周五 15:04写道:

Show quoted text

On Fri, Aug 01, 2025 at 02:56:33PM +0800, Chao Li wrote:

I happened to catch this typo while reading the regression test code, so
submitting a fix.

As the typo is in the code comment, no test needs to run.

Incorrect. The comment is included in the generated output, impacting
also foreign_key.out. If you run a simple `make check` you would see
that the tests fail.
--
Michael

Attachments:

v2-0001-Fixed-a-typo-in-src-test-regress-sql-foreign_key..patchapplication/octet-stream; name=v2-0001-Fixed-a-typo-in-src-test-regress-sql-foreign_key..patchDownload+2-1
#4Michael Paquier
michael@paquier.xyz
In reply to: Chao Li (#3)
Re: Trivial patch to fix a typo

On Fri, Aug 01, 2025 at 03:16:18PM +0800, Chao Li wrote:

Ah ... Good to learn. Attached v2 updated the out file as well, now the
test passed:

$ make check
...
# All 229 tests passed.

That's much better ;)

Applied now down to v18.
--
Michael

#5Chao Li
li.evan.chao@gmail.com
In reply to: Michael Paquier (#4)
Re: Trivial patch to fix a typo

Hi Michael,

Thank you so much for your help. I am new to PG development, I'll keep
learning. :)

Chao Li (Evan)
------------------------------
HighGo Software Inc.
https://www.highgo.com/

Michael Paquier <michael@paquier.xyz> 于2025年8月2日周六 18:55写道:

Show quoted text

On Fri, Aug 01, 2025 at 03:16:18PM +0800, Chao Li wrote:

Ah ... Good to learn. Attached v2 updated the out file as well, now the
test passed:

$ make check
...
# All 229 tests passed.

That's much better ;)

Applied now down to v18.
--
Michael