Remove INT64_HEX_FORMAT and UINT64_HEX_FORMAT
These were introduced (commit efdc7d74753) at the same time as we were
moving to using the standard inttypes.h format macros (commit
a0ed19e0a9e). It doesn't seem useful to keep a new already-deprecated
interface like this with only a few users, so remove the new symbols
again and have the callers use PRIx64.
(Also, INT64_HEX_FORMAT was kind of a misnomer, since hex formats all
use unsigned types.)
[should be backpatched to PG18]
Attachments:
0001-Remove-INT64_HEX_FORMAT-and-UINT64_HEX_FORMAT.patchtext/plain; charset=UTF-8; name=0001-Remove-INT64_HEX_FORMAT-and-UINT64_HEX_FORMAT.patchDownload+6-9
On Sat, Aug 02, 2025 at 11:09:16AM +0200, Peter Eisentraut wrote:
These were introduced (commit efdc7d74753) at the same time as we were
moving to using the standard inttypes.h format macros (commit a0ed19e0a9e).
It doesn't seem useful to keep a new already-deprecated interface like this
with only a few users, so remove the new symbols again and have the callers
use PRIx64.
That seems fine to me.
--
nathan
On Sun, Aug 3, 2025 at 6:25 AM Nathan Bossart <nathandbossart@gmail.com> wrote:
On Sat, Aug 02, 2025 at 11:09:16AM +0200, Peter Eisentraut wrote:
These were introduced (commit efdc7d74753) at the same time as we were
moving to using the standard inttypes.h format macros (commit a0ed19e0a9e).
It doesn't seem useful to keep a new already-deprecated interface like this
with only a few users, so remove the new symbols again and have the callers
use PRIx64.That seems fine to me.
+1
On 04.08.25 05:03, Thomas Munro wrote:
On Sun, Aug 3, 2025 at 6:25 AM Nathan Bossart <nathandbossart@gmail.com> wrote:
On Sat, Aug 02, 2025 at 11:09:16AM +0200, Peter Eisentraut wrote:
These were introduced (commit efdc7d74753) at the same time as we were
moving to using the standard inttypes.h format macros (commit a0ed19e0a9e).
It doesn't seem useful to keep a new already-deprecated interface like this
with only a few users, so remove the new symbols again and have the callers
use PRIx64.That seems fine to me.
+1
done