New commitfest app release on August 19th

Started by Jelte Fennema-Nio7 months ago28 messages
Jump to latest
#1Jelte Fennema-Nio
postgres@jeltef.nl

Thanks to the Claude Code AI tool I was able to get some boring
cleanup done on the CF app in not that much time. I'll release all of
it on August 19th.

List of the changes:
- Update to Bootstrap 5 for more modern visual look and better default
contrast of a bunch of UI elements.
- Add a navigation bar at the top of the page, including a "Contribute
on GitHub" button which links to the CF app repo.
- Move the dashboard to the homepage under the list of commitfests.
- Much better tag selector, which shows the tag descriptions and
colors. (descriptions are also searchable).
- Bugfix where draft patches would show in the wrong section in the
personal dashboard
- Nicer sorting icons for the commitfest columns (exact icon depends
on the column)
- Show Search/Filter options by default
- Improved the typography of date ranges by using an en-dash\

#2Jelte Fennema-Nio
postgres@jeltef.nl
In reply to: Jelte Fennema-Nio (#1)
Re: New commitfest app release on August 19th

On Fri, 8 Aug 2025 at 09:19, Jelte Fennema-Nio <me@jeltef.nl> wrote:

I'll release all of it on August 19th.

As always, you can see the changes live here:

https://commitfest-test.postgresql.org/ (username and password are "pgtest")

Feedback is welcome. Especially if you think something looks off or
buttons don't work (likely caused by the Bootstrap 5 upgrade). I think
I visited all the pages and clicked all the buttons, but I might have
missed a few.

#3Alvaro Herrera
alvherre@2ndquadrant.com
In reply to: Jelte Fennema-Nio (#1)
Re: New commitfest app release on August 19th

On 2025-Aug-08, Jelte Fennema-Nio wrote:

Thanks to the Claude Code AI tool I was able to get some boring
cleanup done on the CF app in not that much time. I'll release all of
it on August 19th.

List of the changes:
- Update to Bootstrap 5 for more modern visual look and better default
contrast of a bunch of UI elements.
- Add a navigation bar at the top of the page, including a "Contribute
on GitHub" button which links to the CF app repo.
- Move the dashboard to the homepage under the list of commitfests.
- Much better tag selector, which shows the tag descriptions and
colors. (descriptions are also searchable).
- Bugfix where draft patches would show in the wrong section in the
personal dashboard
- Nicer sorting icons for the commitfest columns (exact icon depends
on the column)
- Show Search/Filter options by default
- Improved the typography of date ranges by using an en-dash\

Nice stuff. I tried the search, works great, hadn't noticed it before
though now I see it was there already. Maybe the result page could be
improved still, for instance
https://commitfest-test.postgresql.org/search/?searchterm=psql
shows a long list of patches in which it's hard to see which ones are
current, which were Committed, which ones were Returned with Feedback.
(The latter is extremely useful to find old items that were neglected --
I do that all the time, manually, very annoying.)

I hope more widespread use of tags will one day release us from having
the "Topic" categorization, which is not all that useful anymore.

Two minor comments: the tags in the patch page
https://commitfest-test.postgresql.org/patch/5501/
are not clickable, so I can't go to other patches containing the same
tags as this one. This sounds like a trivial fix. Tags are already
clickable in other pages.

The other one I noticed while looking at the prod Draft-CF a couple of
days ago. Here:
https://commitfest-test.postgresql.org/54/
I think the "Closed patches" in the draft CF should not list the patches
that were moved to a future non-draft CF -- that's clutter and serves no
purpose. It still makes sense to list the Draft-CF in the "Status"
section of the patch page itself. (Eh, now I notice that the help page
says at the bottom "Another difference between Draft CommitFests and
regular CommitFests is that Draft CommitFests don't list resolved
patches." which is kinda not true)

Not a fan of the high-contrast buttons (the new black/white elements in
the navigation bar). It feels odd to have everything in gray, except a
too-notorious blue Github button. IMO that button is also too wide --
if I keep the browser window of the same width I typically use (half the
screen) then the menu at the top disappears and is replaced with the
hamburger button, and so becomes unusable.

Many thanks for working on this,

--
Álvaro Herrera Breisgau, Deutschland — https://www.EnterpriseDB.com/
"No nos atrevemos a muchas cosas porque son difíciles,
pero son difíciles porque no nos atrevemos a hacerlas" (Séneca)

#4Jelte Fennema-Nio
postgres@jeltef.nl
In reply to: Alvaro Herrera (#3)
Re: New commitfest app release on August 19th

On Fri, 8 Aug 2025 at 11:55, Álvaro Herrera <alvherre@kurilemu.de> wrote:

Nice stuff.

Thanks for all the feedback. It's super helpful.

I tried the search, works great, hadn't noticed it before
though now I see it was there already. Maybe the result page could be
improved still, for instance
https://commitfest-test.postgresql.org/search/?searchterm=psql
shows a long list of patches in which it's hard to see which ones are
current, which were Committed, which ones were Returned with Feedback.
(The latter is extremely useful to find old items that were neglected --
I do that all the time, manually, very annoying.)

Indeed I just moved the box around this time. It's probably not too
hard to allow searching globally. So I created an issue to track it:
https://github.com/postgres/pgcommitfest/issues/92

I hope more widespread use of tags will one day release us from having
the "Topic" categorization, which is not all that useful anymore.

Yeah, that's something I intend to try out soonish.

Two minor comments: the tags in the patch page
https://commitfest-test.postgresql.org/patch/5501/
are not clickable, so I can't go to other patches containing the same
tags as this one. This sounds like a trivial fix. Tags are already
clickable in other pages.

It's not entirely trivial I guess: What CF should those buttons link
to? The In Progress CF, the Open CF or the last CF that

The other one I noticed while looking at the prod Draft-CF a couple of
days ago. Here:
https://commitfest-test.postgresql.org/54/
I think the "Closed patches" in the draft CF should not list the patches
that were moved to a future non-draft CF -- that's clutter and serves no
purpose. It still makes sense to list the Draft-CF in the "Status"
section of the patch page itself. (Eh, now I notice that the help page
says at the bottom "Another difference between Draft CommitFests and
regular CommitFests is that Draft CommitFests don't list resolved
patches." which is kinda not true)

I think that's fair. How about I simply remove the closed patches
section in Draft CFs completely and make sure a closed/completed patch
is always moved to the open CF? Or do you see any reason to keep the
section?

Not a fan of the high-contrast buttons (the new black/white elements in
the navigation bar). It feels odd to have everything in gray, except a
too-notorious blue Github button.

I'll see if I can make the styling of the buttons a bit better.

IMO that button is also too wide --
if I keep the browser window of the same width I typically use (half the
screen) then the menu at the top disappears and is replaced with the
hamburger button, and so becomes unusable.

Pushed a fix for that now.

#5Jelte Fennema-Nio
postgres@jeltef.nl
In reply to: Jelte Fennema-Nio (#1)
Re: New commitfest app release on August 19th

On Fri, 8 Aug 2025 at 09:19, Jelte Fennema-Nio <me@jeltef.nl> wrote:

Thanks to the Claude Code AI tool I was able to get some boring
cleanup done on the CF app in not that much time. I'll release all of
it on August 19th.

List of the changes:
- Update to Bootstrap 5 for more modern visual look and better default
contrast of a bunch of UI elements.
- Add a navigation bar at the top of the page, including a "Contribute
on GitHub" button which links to the CF app repo.
- Move the dashboard to the homepage under the list of commitfests.
- Much better tag selector, which shows the tag descriptions and
colors. (descriptions are also searchable).
- Bugfix where draft patches would show in the wrong section in the
personal dashboard
- Nicer sorting icons for the commitfest columns (exact icon depends
on the column)
- Show Search/Filter options by default
- Improved the typography of date ranges by using an en-dash

This is now deployed to production. Please let me know if some
behaviour got broken or styling looks weird.

#6Hannu Krosing
hannu@tm.ee
In reply to: Jelte Fennema-Nio (#4)
Re: New commitfest app release on August 19th

On Mon, Aug 11, 2025 at 9:39 AM Jelte Fennema-Nio <me@jeltef.nl> wrote:

On Fri, 8 Aug 2025 at 11:55, Álvaro Herrera <alvherre@kurilemu.de> wrote:

Nice stuff.

...

Two minor comments: the tags in the patch page
https://commitfest-test.postgresql.org/patch/5501/
are not clickable, so I can't go to other patches containing the same
tags as this one. This sounds like a trivial fix. Tags are already
clickable in other pages.

It's not entirely trivial I guess: What CF should those buttons link
to? The In Progress CF, the Open CF or the last CF that

Could be any of these, on a page with tabs or links to others ?

#7Chao Li
li.evan.chao@gmail.com
In reply to: Jelte Fennema-Nio (#5)
Re: New commitfest app release on August 19th

On Aug 19, 2025, at 15:03, Jelte Fennema-Nio <me@jeltef.nl> wrote:

This is now deployed to production. Please let me know if some
behaviour got broken or styling looks weird.

The new UI looks nicer.

But I now aways get “Error 503 Backend fetch failed” when I click on any email link or attachment link.

--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/

#8Jelte Fennema-Nio
postgres@jeltef.nl
In reply to: Chao Li (#7)
Re: New commitfest app release on August 19th

On Tue, 19 Aug 2025 at 09:18, Chao Li <li.evan.chao@gmail.com> wrote:

But I now aways get “Error 503 Backend fetch failed” when I click on any email link or attachment link.

Seems the web-archives are having issues. That's unfortunate timing,
but unrelated to the commitfest app deploy.

#9Michael Paquier
michael@paquier.xyz
In reply to: Chao Li (#7)
Re: New commitfest app release on August 19th

On Tue, Aug 19, 2025 at 03:18:22PM +0800, Chao Li wrote:

But I now aways get “Error 503 Backend fetch failed” when I click on
any email link or attachment link.

That happens from time to time. This is unrelated to the CF app
itself.
--
Michael

#10John Naylor
john.naylor@enterprisedb.com
In reply to: Jelte Fennema-Nio (#5)
Re: New commitfest app release on August 19th

On Tue, Aug 19, 2025 at 2:04 PM Jelte Fennema-Nio <me@jeltef.nl> wrote:

This is now deployed to production. Please let me know if some
behaviour got broken or styling looks weird.

I found the font difficult to read, like it's not rendering smoothly
on my system. While the text looked smaller, I had to zoom out to 75%
in my browser to get the whole table to fit on screen -- anyone else?
(I didn't see font in the list of changes...)

--
John Naylor
Amazon Web Services

#11Jelte Fennema-Nio
postgres@jeltef.nl
In reply to: John Naylor (#10)
Re: New commitfest app release on August 19th

On Tue, 19 Aug 2025 at 09:31, John Naylor <johncnaylorls@gmail.com> wrote:

I found the font difficult to read, like it's not rendering smoothly
on my system. While the text looked smaller, I had to zoom out to 75%
in my browser to get the whole table to fit on screen -- anyone else?
(I didn't see font in the list of changes...)

That's a difference between Bootstrap 3 and Bootstrap 5 I guess.
Before font-family was set to this:

"Helvetica Neue", Helvetica, Arial, sans-serif

Now it's set to this much longer fallback string:

system-ui, -apple-system, "Segoe UI", Roboto, "Helvetica Neue", "Noto
Sans", "Liberation Sans", Arial, sans-serif, "Apple Color Emoji",
"Segoe UI Emoji", "Segoe UI Symbol", "Noto Color Emoji"

Can you check what font is actually being used on your system like this[1]https://devtoolstips.org/tips/en/list-used-fonts/?

[1]: https://devtoolstips.org/tips/en/list-used-fonts/

#12John Naylor
john.naylor@enterprisedb.com
In reply to: Jelte Fennema-Nio (#11)
Re: New commitfest app release on August 19th

On Tue, Aug 19, 2025 at 4:15 PM Jelte Fennema-Nio <me@jeltef.nl> wrote:

Now it's set to this much longer fallback string:

system-ui, -apple-system, "Segoe UI", Roboto, "Helvetica Neue", "Noto
Sans", "Liberation Sans", Arial, sans-serif, "Apple Color Emoji",
"Segoe UI Emoji", "Segoe UI Symbol", "Noto Color Emoji"

Can you check what font is actually being used on your system like this[1]?

[1]: https://devtoolstips.org/tips/en/list-used-fonts/

"Rendered fonts" shows:

Family name: Cantarell (Fontations)
PostScript name: Cantarell-Regular
Font origin: Local file(80 glyphs)

--
John Naylor
Amazon Web Services

#13Alvaro Herrera
alvherre@2ndquadrant.com
In reply to: Jelte Fennema-Nio (#5)
Re: New commitfest app release on August 19th

On 2025-Aug-19, Jelte Fennema-Nio wrote:

This is now deployed to production. Please let me know if some
behaviour got broken or styling looks weird.

Hmm, you seem to have changed the main page title from "Commitfests" to
"CommitFests". There is a subjective argument that the uppercase F in
the middle of that word looks terrible for some reason, but there's also
the objective argument that the change on that particular page broke the
pginfra monitoring for the page.

Can you please put that lowercase "f" back? Here's a quick patch. (I
think several people would not be pleased if the uppercase F were to
propagate much more.)

--
Álvaro Herrera PostgreSQL Developer — https://www.EnterpriseDB.com/

Attachments:

0001-Proper-spelling-is-Commitfest-with-lowercase-f.patchtext/x-diff; charset=utf-8Download+13-14
#14Fujii Masao
masao.fujii@gmail.com
In reply to: Jelte Fennema-Nio (#1)
Re: New commitfest app release on August 19th

On Fri, Aug 8, 2025 at 4:20 PM Jelte Fennema-Nio <me@jeltef.nl> wrote:

Thanks to the Claude Code AI tool I was able to get some boring
cleanup done on the CF app in not that much time. I'll release all of
it on August 19th.

Thanks for your continued work on improving the commitfest app!

I pushed the patch registered in PG19-2 and tried to change its status
to Committed by clicking [Change Status] -> [Committed] in its
commitfest page [1]https://commitfest.postgresql.org/patch/5945/. This worked fine until yesterday, but starting
today, nothing happens when I click it. Could this be related to
today's new release?

Regards,

[1]: https://commitfest.postgresql.org/patch/5945/

--
Fujii Masao

#15Jelte Fennema-Nio
postgres@jeltef.nl
In reply to: Fujii Masao (#14)
Re: New commitfest app release on August 19th

On Tue, 19 Aug 2025 at 12:08, Fujii Masao <masao.fujii@gmail.com> wrote:

I pushed the patch registered in PG19-2 and tried to change its status
to Committed by clicking [Change Status] -> [Committed] in its
commitfest page [1]. This worked fine until yesterday, but starting
today, nothing happens when I click it. Could this be related to
today's new release?

Oops, that was indeed accidentally broken. It's fixed now.

#16Jelte Fennema-Nio
postgres@jeltef.nl
In reply to: Alvaro Herrera (#13)
Re: New commitfest app release on August 19th

On Tue, 19 Aug 2025 at 11:31, Álvaro Herrera <alvherre@kurilemu.de> wrote:

On 2025-Aug-19, Jelte Fennema-Nio wrote:

This is now deployed to production. Please let me know if some
behaviour got broken or styling looks weird.

Hmm, you seem to have changed the main page title from "Commitfests" to
"CommitFests". There is a subjective argument that the uppercase F in
the middle of that word looks terrible for some reason, but there's also
the objective argument that the change on that particular page broke the
pginfra monitoring for the page.

Can you please put that lowercase "f" back? Here's a quick patch. (I
think several people would not be pleased if the uppercase F were to
propagate much more.)

Applied and deployed your patch to make the monitoring happy. Could
you add me to whatever list is necessary for me to receive these
notifications too?

I'm wondering what other people consider the correct spelling though.
The wiki[1]https://wiki.postgresql.org/wiki/CommitFest has been using the spelling with the capital F. As well as
the code for the commitfest app.

[1]: https://wiki.postgresql.org/wiki/CommitFest

#17Aleksander Alekseev
aleksander@timescale.com
In reply to: John Naylor (#10)
Re: New commitfest app release on August 19th

Hi
,

While the text looked smaller, I had to zoom out to 75%
in my browser to get the whole table to fit on screen -- anyone else?
(I didn't see font in the list of changes...)

Same here (Firefox 141, Ubuntu 24.04). I had to scale the page to 90%.

It doesn't bother me too much - just wanted to share in case the
intent was to make the table screen-wide. It seems to be slightly
wider in practice.

--
Best regards,
Aleksander Alekseev

#18Dave Page
dpage@pgadmin.org
In reply to: Jelte Fennema-Nio (#16)
Re: New commitfest app release on August 19th

On Tue, 19 Aug 2025 at 12:06, Jelte Fennema-Nio <me@jeltef.nl> wrote:

On Tue, 19 Aug 2025 at 11:31, Álvaro Herrera <alvherre@kurilemu.de> wrote:

On 2025-Aug-19, Jelte Fennema-Nio wrote:

This is now deployed to production. Please let me know if some
behaviour got broken or styling looks weird.

Hmm, you seem to have changed the main page title from "Commitfests" to
"CommitFests". There is a subjective argument that the uppercase F in
the middle of that word looks terrible for some reason, but there's also
the objective argument that the change on that particular page broke the
pginfra monitoring for the page.

Can you please put that lowercase "f" back? Here's a quick patch. (I
think several people would not be pleased if the uppercase F were to
propagate much more.)

Applied and deployed your patch to make the monitoring happy. Could
you add me to whatever list is necessary for me to receive these
notifications too?

I'm wondering what other people consider the correct spelling though.
The wiki[1] has been using the spelling with the capital F. As well as
the code for the commitfest app.

[1]: https://wiki.postgresql.org/wiki/CommitFest

In the earliest conversations I can find about the idea on -core, we
actually used commit-fest. However, I would say Commitfest is correct, as
that's what we've used for the name on the site for years.

The URL above is a redirect to https://wiki.postgresql.org/wiki/Commitfest

--
Dave Page
pgAdmin: https://www.pgadmin.org
PostgreSQL: https://www.postgresql.org
pgEdge: https://www.pgedge.com

#19Fujii Masao
masao.fujii@gmail.com
In reply to: Jelte Fennema-Nio (#15)
Re: New commitfest app release on August 19th

On Tue, Aug 19, 2025 at 7:57 PM Jelte Fennema-Nio <me@jeltef.nl> wrote:

On Tue, 19 Aug 2025 at 12:08, Fujii Masao <masao.fujii@gmail.com> wrote:

I pushed the patch registered in PG19-2 and tried to change its status
to Committed by clicking [Change Status] -> [Committed] in its
commitfest page [1]. This worked fine until yesterday, but starting
today, nothing happens when I click it. Could this be related to
today's new release?

Oops, that was indeed accidentally broken. It's fixed now.

Thanks for the fix! I was able to change the status to Committed successfully.

Regards,

--
Fujii Masao

#20Tom Lane
tgl@sss.pgh.pa.us
In reply to: Aleksander Alekseev (#17)
Re: New commitfest app release on August 19th

Aleksander Alekseev <aleksander@tigerdata.com> writes:

While the text looked smaller, I had to zoom out to 75%
in my browser to get the whole table to fit on screen -- anyone else?
(I didn't see font in the list of changes...)

Same here (Firefox 141, Ubuntu 24.04). I had to scale the page to 90%.

For me, with Safari on macOS, the font does look a bit different but
not objectionably so. But I too notice that the tables of patches
seem significantly wider than before. If I zoom out enough to fit
the whole table width in my usual browser window, the text is almost
unreadably small. The tables were a bit wider than screen width
already, but it feels like they changed significantly.

regards, tom lane

#21Jelte Fennema-Nio
postgres@jeltef.nl
In reply to: Tom Lane (#20)
#22Alvaro Herrera
alvherre@2ndquadrant.com
In reply to: Jelte Fennema-Nio (#16)
#23John Naylor
john.naylor@enterprisedb.com
In reply to: Jelte Fennema-Nio (#21)
#24vignesh C
vignesh21@gmail.com
In reply to: Jelte Fennema-Nio (#1)
#25Alvaro Herrera
alvherre@2ndquadrant.com
In reply to: Jelte Fennema-Nio (#1)
#26John Naylor
john.naylor@enterprisedb.com
In reply to: John Naylor (#23)
#27Jelte Fennema-Nio
postgres@jeltef.nl
In reply to: John Naylor (#26)
#28John Naylor
john.naylor@enterprisedb.com
In reply to: Jelte Fennema-Nio (#27)