Avoid use of uninitialized variable (src/pl/plperl/plperl.c)

Started by Ranier Vilelaabout 1 year ago3 messageshackers
Beta feature

Hackorum builds and tests every patch posted to the lists, not only commitfest submissions. This is Hackorum's own CI rather than the PostgreSQL project's, and it is still under testing - please report anything that looks wrong.

appliessuccessCI history

You can run a PostgreSQL built from this patch straight from Docker, with no checkout and no build:

docker run --rm -p 5432:5432 ghcr.io/hackorum-dev/postgres-patch:t52220
psql -h localhost -U postgres

Built from patchset v1 (message #1), September 20, 2026 at 09:35 AM.

Every patchset is also pushed to a branch of our PostgreSQL fork, so you can check out the same tree CI built. Without a PostgreSQL checkout:

git clone --branch t52220_1 https://github.com/hackorum-dev/postgres.git

In a checkout you already have, add the fork once:

git remote add hackorum https://github.com/hackorum-dev/postgres.git

then, for this patchset and every later one:

git fetch hackorum t52220_1 && git checkout t52220_1

Patchset v1 (message #1) is on t52220_1

Jump to latest
#1Ranier Vilela
ranier.vf@gmail.com

Hi.

In (src/pl/plperl/plperl.c) if *PERL_SYS_INIT3* is defined and
*MYMALLOC* is not, is possible use of variable
*perl_sys_init_done* uninitialized.

To fix, explicitly initialize the variable.
In pass change type to bool, what was the initial intention.

trivial patch attached.

best regards,
Ranier Vilela

Attachments:

t52220_1
v1-001-avoid-use-uninitialized-variable-plperl.patchapplication/octet-stream; name=v1-001-avoid-use-uninitialized-variable-plperl.patchDownload+2-2
#2Andres Freund
andres@anarazel.de
In reply to: Ranier Vilela (#1)
Re: Avoid use of uninitialized variable (src/pl/plperl/plperl.c)

Hi,

On 2025-09-02 14:39:44 -0300, Ranier Vilela wrote:

In (src/pl/plperl/plperl.c) if *PERL_SYS_INIT3* is defined and
*MYMALLOC* is not, is possible use of variable
*perl_sys_init_done* uninitialized.

Static variables are zero initialized by definition, no?

Greetings,

Andres Freund

#3Ranier Vilela
ranier.vf@gmail.com
In reply to: Andres Freund (#2)
Re: Avoid use of uninitialized variable (src/pl/plperl/plperl.c)

Em ter., 2 de set. de 2025 às 14:42, Andres Freund <andres@anarazel.de>
escreveu:

Hi,

On 2025-09-02 14:39:44 -0300, Ranier Vilela wrote:

In (src/pl/plperl/plperl.c) if *PERL_SYS_INIT3* is defined and
*MYMALLOC* is not, is possible use of variable
*perl_sys_init_done* uninitialized.

Static variables are zero initialized by definition, no?

Yeah. My bad, sorry for the noise.

best regards,
Ranier Vilela