fix type of infomask parameter in static inline functions

Started by Nathan Bossart6 months ago3 messageshackers
Jump to latest
#1Nathan Bossart
nathandbossart@gmail.com

I noticed that a couple of the functions added by commit 34694ec use
"int16" instead of "uint16" for the infomask parameter. I don't think
there are any live bugs here, but IMHO we should at least fix this for v19
to help prevent future problems.

Assuming there is agreement on this change, any thoughts on back-patching?

--
nathan

Attachments:

v1-0001-fix-type-of-infomask-parameter-in-static-inline-f.patchtext/plain; charset=us-asciiDownload+3-4
#2Tom Lane
tgl@sss.pgh.pa.us
In reply to: Nathan Bossart (#1)
Re: fix type of infomask parameter in static inline functions

Nathan Bossart <nathandbossart@gmail.com> writes:

I noticed that a couple of the functions added by commit 34694ec use
"int16" instead of "uint16" for the infomask parameter. I don't think
there are any live bugs here, but IMHO we should at least fix this for v19
to help prevent future problems.

Assuming there is agreement on this change, any thoughts on back-patching?

+1 for changing, but -1 for back-patching. Unless you're itching
for reasons to update .abi-compliance-history. But if there's no
live bug, that seems like make-work.

regards, tom lane

#3Nathan Bossart
nathandbossart@gmail.com
In reply to: Tom Lane (#2)
Re: fix type of infomask parameter in static inline functions

On Wed, Oct 22, 2025 at 05:16:54PM -0400, Tom Lane wrote:

+1 for changing, but -1 for back-patching. Unless you're itching
for reasons to update .abi-compliance-history. But if there's no
live bug, that seems like make-work.

Yeah, makes sense. Committed, thanks for looking.

--
nathan