Extra blank line in StrategyGetBuffer

Started by Ashutosh Bapat6 months ago3 messageshackers
Jump to latest
#1Ashutosh Bapat
ashutosh.bapat@enterprisedb.com

Hi Andres,
It seems that 5e89985928795f243dc287210c2aa016dfd00bfe left an extra
line in StrategyGetBetter(). Doesn't seem to be intentional. But it's
mildly confusing to miss a parentheses on that line. PFA patch fixing
it.

--
Best Wishes,
Ashutosh Bapat

Attachments:

extra_blank_line.difftext/x-patch; charset=US-ASCII; name=extra_blank_line.diffDownload+0-1
#2Bruce Momjian
bruce@momjian.us
In reply to: Ashutosh Bapat (#1)
Re: Extra blank line in StrategyGetBuffer

Agreed, patch applied, thanks.

---------------------------------------------------------------------------

On Tue, Nov 4, 2025 at 02:27:12PM +0530, Ashutosh Bapat wrote:

Hi Andres,
It seems that 5e89985928795f243dc287210c2aa016dfd00bfe left an extra
line in StrategyGetBetter(). Doesn't seem to be intentional. But it's
mildly confusing to miss a parentheses on that line. PFA patch fixing
it.

--
Best Wishes,
Ashutosh Bapat

diff --git a/src/backend/storage/buffer/freelist.c b/src/backend/storage/buffer/freelist.c
index 7fe34d3ef4c..552fcd0f217 100644
--- a/src/backend/storage/buffer/freelist.c
+++ b/src/backend/storage/buffer/freelist.c
@@ -301,7 +301,6 @@ StrategyGetBuffer(BufferAccessStrategy strategy, uint32 *buf_state, bool *from_r
return buf;
}
}
-
}
}
}

--
Bruce Momjian <bruce@momjian.us> https://momjian.us
EDB https://enterprisedb.com

Do not let urgent matters crowd out time for investment in the future.

#3Ashutosh Bapat
ashutosh.bapat@enterprisedb.com
In reply to: Bruce Momjian (#2)
Re: Extra blank line in StrategyGetBuffer

On Sat, Nov 8, 2025 at 8:24 AM Bruce Momjian <bruce@momjian.us> wrote:

Agreed, patch applied, thanks.

Thanks Bruce.

--
Best Wishes,
Ashutosh Bapat