Minor adjustment: Update the range of the commit_siblings parameter.
Hi, hackers
When reviewing the postgresql.conf.sample file, I noticed that the range of the commit_siblings parameter appears to have been incorrect for quite some time. Attached is a simple patch to update it.
--
Regrads,
Man Zeng
Attachments:
001_update_postgresql_conf_sample.patchapplication/octet-stream; charset=ISO-8859-1; name=001_update_postgresql_conf_sample.patchDownload+1-1
On Nov 10, 2025, at 19:04, zengman <zengman@halodbtech.com> wrote:
Hi, hackers
When reviewing the postgresql.conf.sample file, I noticed that the range of the commit_siblings parameter appears to have been incorrect for quite some time. Attached is a simple patch to update it.
--
Regrads,
Man Zeng<001_update_postgresql_conf_sample.patch>
Yes, the definition in guc_parameters.dat shows min as 0 and max as 1000, so the fix is correct:
```
{ name => 'commit_siblings', type => 'int', context => 'PGC_USERSET', group => 'WAL_SETTINGS',
short_desc => 'Sets the minimum number of concurrent open transactions required before performing "commit_delay".',
variable => 'CommitSiblings',
boot_val => '5',
min => '0',
max => '1000',
},
```
Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/
On 10 Nov 2025, at 14:53, Chao Li <li.evan.chao@gmail.com> wrote:
On Nov 10, 2025, at 19:04, zengman <zengman@halodbtech.com> wrote:
When reviewing the postgresql.conf.sample file, I noticed that the range of the commit_siblings parameter appears to have been incorrect for quite some time. Attached is a simple patch to update it.
Yes, the definition in guc_parameters.dat shows min as 0 and max as 1000, so the fix is correct:
Agreed, and MinimumActiveBackends() has a fast-path to handle a value of zero
as well (in all supported back-branches).
We are currently in release freeze for the backbranches, but will commit this
once the tree opens up again backpatched to all supported branches.
--
Daniel Gustafsson