Nov 2025

2 commits
Add test for postgresql.conf.sample line syntax
14 Nov 2025Daniel Gustafssonmaster19beta1REL_19_STABLE19beta1
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #11 of 1 reviewer saw the final version

The commit takes only the test changes from #1, with the configuration fix committed separately. It incorporates Andrew Dunstan's suggestion in #5 to replace ok(0, ...) with fail(), improve diagnostics, and catch uncommented lines after leading whitespace.

  • Andrew Dunstansaw the final versiontrailerAndrew reviewed the test in #5 and supplied the failure-only assertion and broader regular expression used in the committed version.
Comment out autovacuum_worker_slots in postgresql.conf.sample.
14 Nov 2025Nathan Bossartmaster19beta1REL_19_STABLE19beta1REL_18_STABLE18.2
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #13 of 3 reviewers saw the final version

The commit takes only the postgresql.conf.sample fix from #1, adding the same comment marker and adjusting the line's indentation. Nathan explicitly separated this fix from the new test in #7 and confirmed its commit in #8.

  • Tom Lanesaw the final versionLLM analysis, 98% sureTom confirmed that the uncommented setting was a bug and endorsed fixing and backpatching it in #2.
  • Bruce Momjiansaw the final versionLLM analysis, 86% sureBruce agreed with the correction while explaining its effect on newly initialized clusters and configuration comparisons in #3.
  • Nathan Bossartsaw the final versioncommittercommitted the patch

Credits across 2 commits

Author
Daniel Gustafsson2
Reviewer
Andrew Dunstan1
Nathan Bossartcommitter1
Reported by
Daniel Gustafsson1
Committer
Daniel Gustafsson1
Nathan Bossart1