[PATCH] Fix typo in psql \copy command documentation

Started by Ignat Remizov5 months ago3 messageshackers

Jump to latest

Ignat Remizov

ignat980@gmail.com

5 months ago

Hi Postgres hackers,

Small comment typo fix: pstdout was listed twice; first should be pstdin.
Patch inline.

Kind regards,
Ignat Remizov

From a4ae3eb6abd1189a2710b09efd567e46ed9b1f83 Mon Sep 17 00:00:00 2001
From: Ignat Remizov <ignat980@gmail.com>
Date: Sat, 6 Dec 2025 17:30:20 +0200
Subject: [PATCH] Fix typo in psql \copy command documentation

The comment documenting \copy command syntax incorrectly listed
"pstdout" twice. The first instance should be "pstdin" to correctly
reflect that the command accepts both pstdin and pstdout as valid
filename options.

This is a documentation-only change with no functional impact.
---
src/bin/psql/copy.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/bin/psql/copy.c b/src/bin/psql/copy.c
index 92c955b637a..04553c3a33f 100644
--- a/src/bin/psql/copy.c
+++ b/src/bin/psql/copy.c
@@ -33,7 +33,7 @@
  * \copy ( query stmt ) to filename [options]
  *
  * where 'filename' can be one of the following:
- * '<file path>' | PROGRAM '<command>' | stdin | stdout | pstdout | pstdout
+ * '<file path>' | PROGRAM '<command>' | stdin | stdout | pstdin | pstdout
  * and 'query' can be one of the following:
  * SELECT | UPDATE | INSERT | DELETE
  *
-- 
2.43.0

Kirill Reshke

reshkekirill@gmail.com

5 months ago

In reply to: Ignat Remizov (#1)

Re: [PATCH] Fix typo in psql \copy command documentation

On Sat, 6 Dec 2025, 20:39 Ignat Remizov, <ignat980@gmail.com> wrote:

Hi Postgres hackers,

Small comment typo fix: pstdout was listed twice; first should be pstdin.
Patch inline.

Kind regards,
Ignat Remizov

From a4ae3eb6abd1189a2710b09efd567e46ed9b1f83 Mon Sep 17 00:00:00 2001
From: Ignat Remizov <ignat980@gmail.com>
Date: Sat, 6 Dec 2025 17:30:20 +0200
Subject: [PATCH] Fix typo in psql \copy command documentation

The comment documenting \copy command syntax incorrectly listed
"pstdout" twice. The first instance should be "pstdin" to correctly
reflect that the command accepts both pstdin and pstdout as valid
filename options.

This is a documentation-only change with no functional impact.
---
src/bin/psql/copy.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/bin/psql/copy.c b/src/bin/psql/copy.c
index 92c955b637a..04553c3a33f 100644
--- a/src/bin/psql/copy.c
+++ b/src/bin/psql/copy.c
@@ -33,7 +33,7 @@
* \copy ( query stmt ) to filename [options]
*
* where 'filename' can be one of the following:
- * '<file path>' | PROGRAM '<command>' | stdin | stdout | pstdout |
pstdout
+ * '<file path>' | PROGRAM '<command>' | stdin | stdout | pstdin | pstdout
* and 'query' can be one of the following:
* SELECT | UPDATE | INSERT | DELETE
*
--
2.43.0

Hi!
Your patch WFM.

But i want to remind you can people usually send patches here as file.
Well, for single liners including patch directly in message body is OK, but
in nearby thread you did same for relatively big change so...

My recipe is coding locally, then git commit and git format-patch -v
whatever-version -1 sha-of-commit

Sorry for being nitpicky

LGTM

Best regards,
Kirill Reshke

Bruce Momjian

bruce@momjian.us

4 months ago

In reply to: Kirill Reshke (#2)

Re: [PATCH] Fix typo in psql \copy command documentation

On Sun, Dec 7, 2025 at 12:42:14AM +0500, Kirill Reshke wrote:

Your patch WFM.

But i want to remind you can people usually send patches here as file. Well,
for single liners including patch directly in message body is OK, but in nearby
thread you did same for relatively big change so...

My recipe is coding locally, then git commit and git format-patch -v
whatever-version -1 sha-of-commit

Great, patch applied.

--
Bruce Momjian <bruce@momjian.us> https://momjian.us
EDB https://enterprisedb.com

Do not let urgent matters crowd out time for investment in the future.